Repository navigation
sync: review anticipated upstream baseline and isolate remaining fork work #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b21d005
3acf607
c548451
657120c
b86d59f
7799de8
3f9a5bc
1d8572f
b3e871d
a3ccd2e
6df0e56
aacf5d1
af75c8c
c860980
f71fa03
c4b2efc
144d0c1
d0b31f4
5b45d09
f9cf729
9d888f1
a37a642
578915c
592ddd7
bcf52af
8dda16d
e877e13
2775faf
ef80481
5f73b70
52feb60
3c9d352
9fc2f71
5c54ee6
75d9e0b
ea974a2
d9ea982
f4a949b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,19 @@ | ||
| ## Summary | ||
| ## Change and reason | ||
|
|
||
| <!-- What does this PR do, and why? One logical change per PR. --> | ||
| <!-- One logical change. Link relevant issues without claiming to close unrelated work. --> | ||
|
|
||
| Closes # | ||
| ## Validation | ||
|
|
||
| ## Type of change | ||
| <!-- Exact commands, results, and Julia/R/bun versions actually tested. | ||
| State explicitly what was not run. --> | ||
|
|
||
| - [ ] 🐛 Bug fix (non-breaking change that fixes an issue) | ||
| - [ ] ✨ New feature (non-breaking change that adds functionality) | ||
| - [ ] 💥 Breaking change (would change existing behaviour, a config key or an API response) | ||
| - [ ] 📊 Statistics fix (a method returned a wrong number, or a result it could not support) | ||
| - [ ] 📖 Documentation | ||
| - [ ] 🧹 Refactor / tech debt (behaviour-preserving) | ||
| - [ ] ⚡ Performance | ||
| - [ ] 🔧 Build / CI / tooling | ||
| ## Scope | ||
|
|
||
| ## How has this been verified? | ||
| <!-- What related work is left out? Explain any necessary lockfile change. --> | ||
|
|
||
| <!-- Name the commands you ran and what they reported. For example: | ||
| julia --project=. test/runtests.jl | ||
| julia --project=. -t 2 test/runtests.jl --integration --server | ||
| cd frontend && bun run test --> | ||
| ## Contribution checks | ||
|
|
||
| Tested with Julia `…`, R `…` and bun `…`. | ||
|
|
||
| ## What this leaves out | ||
|
|
||
| <!-- Anything related that this PR does not do, and why. --> | ||
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] My branch starts at the current tip of `main` (`behind_by` is `0`; see CONTRIBUTING.md) and has no merge commits from `main`. | ||
| - [ ] I ran `julia --project=. test/runtests.jl` (and `cd frontend && bun run test` for frontend changes) and they pass. | ||
| - [ ] CI ran on this PR and passes. | ||
| - [ ] No generated or vendored files, and no lockfile change the work does not need (or the reason is given above). | ||
| - [ ] New code is AGPL-3.0, or MPL-2.0 with an SPDX identifier in each file I wrote. I left existing file headers, `LICENSE`, `CITATION.cff` and the licence and acknowledgement sections of `README.md` unchanged. | ||
| - [ ] Every number shown to a user is computed from their data. When a method cannot run it raises an explicit error. | ||
| - [ ] Docs are updated, and no claim in them overstates what the code does. | ||
|
|
||
| ## Notes for reviewers | ||
|
|
||
| <!-- Anything that needs special attention, follow-up, or context. To be considered for authorship in CITATION.cff, say so here. --> | ||
| - [ ] I followed [CONTRIBUTING.md](../CONTRIBUTING.md). | ||
| - [ ] This branch starts at current upstream main and contains no merges from fork main. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Match the branch check to
🤖 Prompt for AI Agents |
||
| - [ ] CI has run and passes. | ||
| - [ ] Existing licensing, citation and acknowledgement text is unchanged. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use a level-one heading first.
The template starts with an H2. The supplied markdownlint-cli2 report flags MD041 because the first line should be a top-level heading. Change it to
# Change and reason.🧰 Tools
🪛 markdownlint-cli2 (0.23.3)
[warning] 1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🤖 Prompt for AI Agents
Source: Linters/SAST tools