Repository navigation
ci(occupancy): move the PR path filter into a gate, so the reading ch… - #137
Closed
hyperpolymath wants to merge 2 commits into
Closed
hyperpolymath wants to merge 2 commits into
hyperpolymath wants to merge 2 commits into
Conversation
…ecks can be required #116 merged with this workflow's "Occupancy typed peak" check red (its squash carried a draft `TH.[_]` placeholder; #117 fixed the proof), because nothing required the check to pass first -- and nothing could have: the pull_request trigger was path-filtered, so the check never posted on PRs that touch no occupancy file, and a required check that never posts can never be satisfied. The path filter now lives in an `Occupancy relevance` gate job: the workflow runs on every PR, the gate diffs the change against the same file list (plain `case` globs; a third-party paths-filter action is refused by the account's allow-list), and the two heavy jobs run only when it matches -- posting `skipped` otherwise, which a required check counts as satisfied. All three job names are stable identifiers with no matrix, as test_install_pins.jl asserts for every job in every workflow. Branch-Floor can then require `Occupancy relevance` (itself included: a failed gate skips its dependents, and a skipped check satisfies a requirement -- the gate is the one check that must not be skipped silently), `Occupancy disagreement test`, `Occupancy typed peak`, alongside ci.yml's `Julia tests` and `Agda proofs`. That ruleset change is a settings change, kept out of this PR on purpose. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…etamanifold-webui
|
Owner
Author
hyperpolymath
deleted the
arena/a90f767d-df92-43cd-9976-e9eb37b5d749-metamanifold-webui
branch
October 15, 2026 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ecks can be required
#116 merged with this workflow's "Occupancy typed peak" check red (its squash carried a draft
TH.[_]placeholder; #117 fixed the proof), because nothing required the check to pass first -- and nothing could have: the pull_request trigger was path-filtered, so the check never posted on PRs that touch no occupancy file, and a required check that never posts can never be satisfied.The path filter now lives in an
Occupancy relevancegate job: the workflow runs on every PR, the gate diffs the change against the same file list (plaincaseglobs; a third-party paths-filter action is refused by the account's allow-list), and the two heavy jobs run only when it matches -- postingskippedotherwise, which a required check counts as satisfied. All three job names are stable identifiers with no matrix, as test_install_pins.jl asserts for every job in every workflow.Branch-Floor can then require
Occupancy relevance(itself included: a failed gate skips its dependents, and a skipped check satisfies a requirement -- the gate is the one check that must not be skipped silently),Occupancy disagreement test,Occupancy typed peak, alongside ci.yml'sJulia testsandAgda proofs. That ruleset change is a settings change, kept out of this PR on purpose.Generated by Mistral Vibe.
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers