Repository navigation
Fix/stable required check name - #129
hyperpolymath wants to merge 3 commits into
Conversation
Closes #38. The `test` job was named `Julia ${{ matrix.julia-version }} / ${{ matrix.os }}`, and that string is what branch ruleset 23793298 requires as a status check. A ruleset matches a required check by display name. Bumping either pin renamed the check, and a renamed check does not report at all -- it does not fail, it is simply absent, and an absent required check can never be satisfied. Every open pull request would have deadlocked until an admin bypassed the rule. The trigger was an ordinary version bump: the single most routine edit this repository gets. Both halves of the name interpolated, so the OS pin carried the same fault as the Julia pin. Measured, by parsing three hypothetical bumps through both versions of the file: matrix before after 1.12.5 / ubuntu-24.04 "Julia 1.12.5 / ubuntu-24.04" "Julia tests" 1.12.6 / ubuntu-24.04 "Julia 1.12.6 / ubuntu-24.04" "Julia tests" 1.13.0 / ubuntu-26.04 "Julia 1.13.0 / ubuntu-26.04" "Julia tests" The versions are not hidden, only moved off the identifier: they remain in `strategy.matrix` and in the `Set up Julia` step's log. `test/unit/test_install_pins.jl` gains a reflexive testset asserting that NO job name in ci.yml interpolates anything. It is written over every job rather than over the one job we require today, because a rule enforced at each door in turn is a rule the next door escapes. Verified by killing the mutant: against the unedited ci.yml the assertion fails on exactly one job of three (97 pass / 1 fail), and passes 98/98 after the rename. The job ID `test` is unchanged, so `needs: [test]` and the existing `ci["jobs"]["test"]` assertions are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm (cherry picked from commit 8a098d2)
#39 renamed this job to `Julia tests` and claimed the required status check was therefore version-stable. It was not, and the claim was never measured. MEASURED on PR #39 head 776e340, after that change had landed: Julia tests (1.12.5, ubuntu-24.04) <- what GitHub actually posted Julia tests <- what the ruleset requires GitHub appends the matrix combination to a job's posted check name whenever the `name:` does not itself reference the matrix. The old interpolating name suppressed the suffix by accident; replacing it with a static string turned the suffix on. A 1x1 matrix is still a matrix, so both pins stayed embedded in the check name and the required context `Julia tests` was never reported at all -- so `main` has been sitting in precisely the deadlock issue #38 describes, with #39 itself merged only by an admin bypass. The matrix selected exactly one combination and bought nothing, so it is removed rather than worked around: `runs-on: ubuntu-24.04` and the setup-julia `version: "1.12.5"` are literals, each keeping the reasoning that used to sit beside the matrix entry. The non-matrix `repo-hygiene` job was the control -- it has always posted its `name:` verbatim. Why the guard did not catch it: `test_install_pins.jl` asserted that no job name interpolates anything -- a property of the YAML `name:` field -- while the consumer, the ruleset, matches the rendered check-run name. The guard asked a different question than its consumer, so it passed on a broken fix. It now asserts BOTH necessary conditions, over every job in the file: the name interpolates nothing AND the job has no `strategy.matrix`. Run against the previous commit that assertion fails on `test` alone (5 pass / 1 fail), so it discriminates rather than blanket-failing. `CI installs what is pinned` made the same claims about the same two values and has been repointed at where they now live, locating the setup step by its `uses:` rather than by index. Mutating either literal fails it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm (cherry picked from commit 6c29b53)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F6qhB21oLqSPK261cRy5R8
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Resolved by inspection rather than rebase: this branch's work is already on main, in stronger form, so a conflict resolution would only revert main. Verified piece by piece -- (1) main's ci.yml carries the fixed The branch can be deleted; the historical record stays in its commits and in #39's measurement. |
1 participant
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers