Skip to content

Change small PR to well scoped #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joostlek wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Draft

Change small PR to well scoped #3037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/review-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ do to make it easier to review your PR. This will not only help reviewers
but also you as a contributor to having your change merged quicker, and
the end-user getting your improvement faster.

1. **Make your PRs as small as possible.**
1. **Make sure your PRs are well-scoped.**
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's that unclear. We talk about size and scope below. And we say "as small as possible". A config flow PR is as small as possible if the user can complete the user flow and errors and abort cases are handled.

A PR should only refactor one thing, fix one thing, add one feature, or
adjust a single subject in the documentation. If you want to change multiple
things, please create multiple PRs. Smaller PRs have a smaller scope, need
Expand Down