Skip to content

Change small PR to well scoped#3037

Draft
joostlek wants to merge 1 commit intohome-assistant:masterfrom
joostlek:well-scoped
Draft

Change small PR to well scoped#3037
joostlek wants to merge 1 commit intohome-assistant:masterfrom
joostlek:well-scoped

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Apr 7, 2026

Proposed change

Change small PR to well scoped as I think that small PR can be interpret as small in lines of code, while with a PR where you for example add a config flow, it will be inherently big, but if that is the only change you're making, that's fine as its well-scoped. So by using the word well-scoped instead we make it clearer what we expect.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features for which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Remove stale or deprecated documentation

Checklist

  • I have read and followed the documentation guidelines.
  • I have verified that my changes render correctly in the documentation.

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to relevant existing code or pull request:

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

Warning

Rate limit exceeded

@joostlek has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bcae2e43-26a1-4286-aeb6-18ef9c5c39a1

📥 Commits

Reviewing files that changed from the base of the PR and between 12d432f and d33ecd9.

📒 Files selected for processing (1)
  • docs/review-process.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread docs/review-process.md
the end-user getting your improvement faster.

1. **Make your PRs as small as possible.**
1. **Make sure your PRs are well-scoped.**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's that unclear. We talk about size and scope below. And we say "as small as possible". A config flow PR is as small as possible if the user can complete the user flow and errors and abort cases are handled.

@MartinHjelmare MartinHjelmare marked this pull request as draft April 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants