Skip to content

test(check-links): pin has_id's metacharacter escaping and <a ... name=> after other attributes #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hivecommons-hive merged 1 commit into from
Oct 29, 2026
Merged

test(check-links): pin has_id's metacharacter escaping and <a ... name=> after other attributes #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scripts/check-links.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,18 @@ expect_out 'anchor missing: index\.html -> /t\.html#viewport' "meta name is not
expect_out 'anchor missing: index\.html -> /t\.html#a\.b' "dot in an anchor is literal"
expect_no_out 'anchor missing: index\.html -> /t\.html#(ok|named|x\.y)' "real id, <a name> and literal-dot anchors still pass"

echo "case: every ERE metacharacter in an anchor is literal, in both the id= and <a name=> arms"
root="$(new_site anchor-metachars)"
printf '<a href="/t.html#a+b">a</a><a href="/t.html#q(1)">b</a><a href="/t.html#n.m">c</a><a href="/t.html#c+d">d</a><a href="/t.html#r(2)">e</a><a href="/t.html#with-attrs">f</a>' > "$root/index.html"
printf '<p id="top"></p><p id="aab"></p><p id="q1"></p><a name="nzm"></a><p id="c+d"></p><a name="r(2)"></a><a class="x" href="#top" name="with-attrs">top</a>' > "$root/t.html"
run_checker "$root"
expect_rc 1 "unescaped-metachar false passes fail"
expect_out 'anchor missing: index\.html -> /t\.html#a\+b' "plus in an id= anchor is literal"
expect_out 'anchor missing: index\.html -> /t\.html#q\(1\)' "parens in an id= anchor are literal"
expect_out 'anchor missing: index\.html -> /t\.html#n\.m' "dot in an <a name> anchor is literal"
expect_no_out 'anchor missing: index\.html -> /t\.html#(c\+d|r\(2\)|with-attrs)' "literal metachar ids, metachar <a name> and <a ... name=> after other attributes still pass"
expect_out 'Internal errors: 3\.' "only the three false passes counted"

echo "case: single-quoted and unquoted href/src are checked; ?src= and empty href are not"
root="$(new_site quoting-forms)"
cat > "$root/index.html" <<'HTML'
Expand Down
Loading