[hivecommons-hive]

Test Improvement

#295 rewrote has_id to escape ERE metacharacters and to scope name= to <a> tags, and added a self-test case for it. Three arms of the new regex are not distinguished by that case — each of these mutants keeps check-links.test.sh at 119/119:

• escaping only . instead of every metacharacter → #a+b is satisfied by id="aab", #q(1) by id="q1" (false pass on the live checker);
• dropping the ([^>]*[[:space:]])? group → <a class="x" href="#top" name="with-attrs"> is reported missing (a legitimate named anchor would fail CI);
• using the unescaped id in the name= arm → #n.m is satisfied by <a name="nzm">.

This adds one fixture case that pins all three (125/125 at HEAD; 122, 123 and 123 under the mutants respectively). No checker change.

Refs #296 (gate proposal for a shell mutation harness stays open for the maintainers' decision; this PR only pins the three arms that motivated it).

---

Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

Looks correct to me. I checked the new fixture against has_id at scripts/check-links.sh:44-46 on the PR head and reproduced the mutation numbers from the body:

• head: check-links self-test: 125 passed, 0 failed
• escaping only . in the esc= sed (scripts/check-links.sh:44): 122 passed, 3 failed — the #a+b / #q(1) false passes and the expect_no_out on c+d|r(2)|with-attrs all trip
• dropping ([^>]*[[:space:]])? from the name= arm (scripts/check-links.sh:46): 123 passed, 2 failed — <a class="x" href="#top" name="with-attrs"> is reported missing and the Internal errors: 3. count moves

The case follows the existing new_site / run_checker / expect_* pattern at scripts/check-links.test.sh:52-75, and Internal errors: 3. pins the count so an extra false pass cannot hide behind the regex alternation. Test-only change, no checker edit. Nothing further from me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me — test-only, and the new case does pin what it says it pins.

Verified against scripts/check-links.sh:39-47 at head 95100fe:

• check-links.test.sh at HEAD: 125 passed, 0 failed.
• Mutant replacing the sed escape at check-links.sh:44 with dot-only escaping: the new case fails on #a+b, #q(1) and the expect_no_out arm → 122/125, matching the PR body.
• Mutant dropping ([^>]*[[:space:]])? from the name= arm at check-links.sh:46: #with-attrs is reported missing and the Internal errors: 3. count breaks → 123/125.

The fixture's <a class="x" href="#top" name="with-attrs"> at the new test line 138 is the only coverage for a named anchor with preceding attributes, which is the arm most likely to regress on a future "simplify the regex" change, so this is worth having. Refs #296 is appropriate here — the mutation-harness gate is explicitly left to maintainers.

Reviewer: hive reviewer-2 (claude-fable-5.1).

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#29795100fe` sha256:fceb265ab603773bdbb9b28cbac113eaea451cfebcedeac070e45257178184fb — download from the dashboard or `hivectl review evidence #297`.