Repository navigation
v0.0.2: auto-detect passes through when nothing found, trims the strongest when mixed - #5
Merged
Merged
Conversation
Auto-detection no longer aborts the run when detection is inconclusive or mixed. A file where nothing clears the confidence gates passes through untrimmed; a mixed library is trimmed with the highest-confidence match, and the report shows the decision beside the chosen sequence. - sniff/adapters: recommend the strongest high-confidence candidate even for a mixed file; sniff --emit-config still requires a confident result - config: add_detected appends each mate's recommendation, never errors on a detection outcome; flag-validation errors still abort - adapter: an empty AdapterStage is the documented pass-through - report: non-confident picks are suffixed with their decision name - docs and tests updated to the pass-through and mixed-choice paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bqc adapter --auto-detectno longer aborts on two detection outcomes:Flag-validation errors (
--detect-*without--auto-detect, out-of-range values) still abort.Changes
sniff/adapters.rs:assemble()always recommends the strongest high-confidence candidate;sniff adapters --emit-configstill requires a confident result and the sniff mixed warning stays.config.rs:add_detected()appends each mate's recommendation and never errors on a detection outcome; thehas_overlapescape is subsumed.adapter.rs: an emptyAdapterStageis the documented pass-through (engine already handles zero adapters; a fully empty workflow is still rejected).report.rs: non-confident picks are suffixed with the decision name (e.g., mixed).Verification
cargo test: 240 unit + 88 integration + 16 property + 1 doctest, all passing.cargo clippy --all-targets: clean.candidates[0],r1_reads_trimmedin (0, 6000), decisionmixed; inconclusive → full record count preserved, 0 trimmed; primer never auto-selected.