refactor(mac): drop UserDefaults review-marks import - #157
Closed
hewigovens wants to merge 1 commit into
Closed
Conversation
Review marks have lived in the shared review_store.json since the store moved out of UserDefaults. The one-time jayjay.reviewedFiles import only ran when that file was missing; remove it now that that window has passed. Leftover UserDefaults keys are ignored.
5 tasks
hewigovens
added a commit
that referenced
this pull request
Aug 21, 2026
Make the always-loaded AGENTS.md an ordered agent loop: sibling jj workspace, snapshot discipline, package-scoped inner-loop tests, two dedupe/simplify cleanup rounds before a task is done, then one jj fix + just lint pass. Feature PRs no longer touch the user guide, Help Book, website, or parity matrix; those move to a shipped-docs pass in the release flow, and UserGuide.md becomes a stub pointing at docs/guide.html. Add just test-rust and a test-id argument for just test-ui, and drop SwiftLint file_length in favor of splitting by responsibility. Fold in the trims from the closed #156 and #157: GitHub-only PR publish (Codeberg stays open/compose only in-app), no sccache fallback, no Architecture Boundaries / Testing restatements in AGENTS.md, shorter shell-parity Yes rows, review-state persistence pointing at the Storage Guide, a Swift Tests section, and no legacy-import mentions. Focused guides now carry only what AGENTS.md leaves out instead of repeating its command blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the one-time
jayjay.reviewedFilesUserDefaults import from the SwiftUIReviewStore. Marks have lived in the sharedreview_store.jsonsince that store moved out of UserDefaults; the import only ran when the JSON file was missing.Leftover
jayjay.reviewedFileskeys are ignored. Also drop the matching test and the storage/review-state mentions.Stacked on #156 because that change already rewrites the two agent guides.
Test plan
ReviewStoreno longer reads or deletesjayjay.reviewedFilestestLegacyDefaultsImportOnFirstRunis gone; remainingReviewStoreTestsstill cover marks, notes, and concurrent writesjust test-app(macOS) — not run in this Linux environment