docs: agent feature loop with two cleanup rounds; trim guides - #158
Merged
Conversation
Review marks have lived in the shared review_store.json since the store moved out of UserDefaults (June 2026). The one-time jayjay.reviewedFiles import only ran while that file was missing; remove it and its test now that the window has passed. Leftover UserDefaults keys are ignored.
Make the always-loaded AGENTS.md an ordered agent loop: sibling jj workspace, snapshot discipline, package-scoped inner-loop tests, two dedupe/simplify cleanup rounds before a task is done, then one jj fix + just lint pass. Feature PRs no longer touch the user guide, Help Book, website, or parity matrix; those move to a shipped-docs pass in the release flow, and UserGuide.md becomes a stub pointing at docs/guide.html. Add just test-rust and a test-id argument for just test-ui, and drop SwiftLint file_length in favor of splitting by responsibility. Fold in the trims from the closed #156 and #157: GitHub-only PR publish (Codeberg stays open/compose only in-app), no sccache fallback, no Architecture Boundaries / Testing restatements in AGENTS.md, shorter shell-parity Yes rows, review-state persistence pointing at the Storage Guide, a Swift Tests section, and no legacy-import mentions. Focused guides now carry only what AGENTS.md leaves out instead of repeating its command blocks.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88dcbac648
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #156 and #157 (closed Cursor cloud-agent PRs), merged onto the local docs rework. Two changes:
docs: agent feature loop with two cleanup rounds; trim guides
AGENTS.mdis now an ordered agent loop: sibling jj workspace → snapshot discipline → package-scoped inner-loop tests → two dedupe/simplify cleanup rounds before a task is done → onejj fix+just lintpass → describe. Architecture Boundaries / Testing restatements are folded into Principles 4 and 7.agents/release.md.UserGuide.mdbecomes a stub pointing atdocs/guide.html.just test-rust <crate> [args]andjust test-ui [test-id]; SwiftLintfile_lengthdropped in favor of splitting by responsibility.testing.md,version-control.md) now carry only whatAGENTS.mdleaves out instead of repeating its command blocks.code-review.mdgains a check for leftovers the cleanup rounds should have removed.refactor(mac): drop UserDefaults review-marks import (= #157)
jayjay.reviewedFilesimport fromReviewStore.swiftand its test. The sharedreview_store.jsonhas been the store since June 2026; leftover UserDefaults keys are ignored.Not adopted from #156: "work in the current workspace by default" — the loop keeps sibling workspaces as the default.
Test plan
xcodebuild … -only-testing:JayJayTests/ReviewStoreTests— build + 9 tests passjust shell::lint(swiftlint) clean;jj fixno-opjust -n test-rust jayjay-core working_copy/just -n test-ui <id>expand correctly;just listshows the new recipesAGENTS.md,CONTRIBUTING.md,agents/*.md