Repository navigation
Platform UI leaves boring-ui: the shell gets a generic agent slot - #1958
Merged
Merged
Conversation
PM panel, task board, task mentions, requests board and the feedback blocks
move to boring-factory's platform-ui/. boring-ui no longer imports any of them.
- AppShell `improve` is a generic AgentSlot { Provider, Layout, spec? }
- PiChat `sentContent`: a host's card for a sent text
- AgentSpec.feedback removed (no app used it); chatProps.feedback stays
- voice-input moves to pi-chat-voice; @hachej/boring-feedback stays a package
- shadcn/ holds the primitives the Factory's bundle will compile (step 2)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main landed the same seam. pmPanel moves to the Factory with the PM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of design v2, boring-ui side. Replaces #1955. The Factory side is hachej/boring-factory, branch
feat/template-ui-from-registry.What changes
pm-panel,task-board,task-mentions,requests-board,feedback,feedback-preview, and the kit'ssrc/task-board.ts, with their tests and examples.ShellPanelfrom AppShell has a general panel place; the PM plugs into it #1956, already on main. This PR movespmPanelout with the PM, so boring-ui imports no PM code.PiChat sentContent: a host supplies the card for a sent text.pi-chatno longer imports@hachej/boring-feedback.shadcn/, for the bundle in step 2.build-blocks.mjsand theplaced-agentcasts come with step 2. Npm exports, peers and theaudiencemove are dropped.Decisions to check
AgentSpec.feedbackis removed, which also removes point mode on an app's own assistant from the shell. Coach Max, Studio and Idea Lab don't use it. A composer's annotate toggle stays throughchatProps.feedback, but its block now lives in the Factory.@hachej/boring-feedbackstays here as a package:agent-targetandpackages/agentuse it. Only its blocks moved.voice-inputstays here, inpi-chat-voice: it passes the Coach Max test.task-list-viewerstays here: it shows an agent's own task list.Coverage removed from this repo
mockup:journeyanddiagram:journey, and point-mode steps inapp-shell:journey. The pin proofs now run as Factory unit tests only, so no browser journey covers them.examples/feedbackbrowser page and journeys, which were not in CI.FEEDBACK-*proof rows for the two moved test files, removed fromVERIFY.json.Tests
Run locally:
node scripts/run-tests.mjs: 2515 pass, 0 fail, on the merged treeverify-repopasses on the final treeapp-shell:journey,:workspace,:voicemockup:journey,diagram:journey,workspace-app:journeyMerge safety
Published kit versions, including the in-flight 0.4.46 (#1957), keep these blocks, so apps on pinned copies are unaffected. Don't adopt into
templates/appany kit release cut after this PR, before step 3: those releases no longer contain these blocks.🤖 Generated with Claude Code