Repository navigation
The pointing tool returns to boring-ui: feedback block and AgentSpec.feedback - #1959
Merged
Merged
Conversation
…feedback Any app can switch it on, on the composer and on the surface. pi-chat keeps the generic sentContent hook; the shell fills it for an agent with feedback on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julien's decision: the pointing tool belongs to boring-ui, something any app can switch on, on the composer and on the surface. This undoes that part of #1958. PM-specific wiring stays in the Factory.
Why now: Coach Max passes a feedback session on Max's spec (trunk 178d745, reported by the Coach Max session; I haven't read that repo). #1958 removed
AgentSpec.feedback, so the next kit would fail its typecheck and lose the feature.What changes
feedbackitem is back: same files as before Platform UI leaves boring-ui: the shell gets a generic agent slot #1958, plus the sent report's card (feedback-content.ts,sent-feedback.tsx,sent-content.tsx).voice-inputstays inpi-chat-voice.AgentSpec.feedbackis back: the composer'scomposer-annotatetoggle, the note bubble, point mode and the comment banner, as the shell had them.app-shelldepends onfeedbackagain.VERIFY.jsonrows, token tests,features/feedback.mdand the README sections.Decisions to check
pi-chatstays free of feedback. It keeps Platform UI leaves boring-ui: the shell gets a generic agent slot #1958's genericsentContenthook. The shell fills it for an agent with feedback on, and a host's ownsentContentwins. Api-chatused without the shell shows a sent report as plain text unless the host passessentFeedbackContent.feedback-previewstays in the Factory. The decision named the composer and the surface; the preview banner is neither. Say if it should come back too.Tests
Run locally:
npm run check: exit 0test/contracts/app-shell-render.impl.mjs: 54 pass, including two new tests. One covers the toggle and the layer stepping aside on a phone; the other covers the sent report's content.pi-chatsource tests: 80 pass.app-shell-source: 30 pass.test:feedback-registry-consumer,test:pi-chat-consumer,test:app-registry-consumerall pass.The feedback install test had a stale dependency list (no
class-variance-authority), now fixed. It was not in CI before #1958 either, and this PR doesn't add it.Not in this PR
platform-ui/feedback/still exists, so there are two copies until a Factory PR moves the PM onto this block.examples/feedbackbrowser journeys and the feedback scenario, which were not in CI.🤖 Generated with Claude Code