Skip to content

Techdebt/update core#116

Merged
kcw-grunt merged 10 commits into
developfrom
techdebt/update-core
Jun 8, 2026
Merged

Techdebt/update core#116
kcw-grunt merged 10 commits into
developfrom
techdebt/update-core

Merge branch 'develop' into techdebt/update-core

e4e930a
Select commit
Loading
Failed to load commit list.
Xcode Cloud / brainwallet | Unit Testing - Every Push | Archive - iOS required action Jun 8, 2026 in 5m 30s

1 error, 97 warnings

Report Summary
Errors 1
Test Failures 0
Analysis Issues 0
Warnings 97

Details

1 Error

Details

  Could not get GOOGLE_APP_ID in Google Services file from build environment

97 Warnings

Details

  brainwallet/ReachabilityMonitor.swift:35
      'SCNetworkReachabilitySetCallback' was deprecated in iOS 17.4
  brainwallet/WalletManager+Auth.swift:392
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Legacy_BW_BRClasses/BRKeyExtension.swift:47
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/PaymentProtocol.swift:183
      'SecTrustCopyPublicKey' was deprecated in iOS 14.0: renamed to 'SecTrustCopyKey(_:)'
  brainwallet/ModalTransitionDelegate.swift:39
      Switch covers known cases, but 'UIGestureRecognizer.State' may have additional unknown values, possibly added in future versions; this is an error in the Swift 6 language mode
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:14
      Initialization of 'UnsafeMutableRawPointer' results in a dangling pointer
  brainwallet/WalletManager+Auth.swift:530
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:156
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Additions/UIButton+BRWAdditions.swift:11
      Initialization of immutable value 'titleSize' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/WalletCoordinator.swift:258
      'applicationIconBadgeNumber' was deprecated in iOS 17.0: Use -[UNUserNotificationCenter setBadgeCount:withCompletionHandler:] instead.
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:36
      Initialization of 'UnsafeRawPointer' results in a dangling pointer
  brainwallet/Settings Classes/SettingsExpandingBlockchainView.swift:72
      'animation' was deprecated in iOS 15.0: Use withAnimation or animation(_:value:) instead.
  brainwallet/Bento Views/Game Hub Bentos/SocialsView.swift:29
      Initialization of immutable value 'width' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Extensions/Extensions.swift:237
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  Modules/core/BRPeerManager.c:837
      Unused variable 'thread'
  brainwallet/Bento Views/Game Hub Bentos/MoonPayView.swift:31
      Initialization of immutable value 'height' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Legacy_BW_BRClasses/BRMasterKeyExtension.swift:4
      Extension declares a conformance of imported type 'BRMasterPubKey' to imported protocol 'Equatable'; this will not behave correctly if the owners of 'BRCore' introduce this conformance in the future
  brainwallet/Extensions/Extensions.swift:168
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/ReachabilityMonitor.swift:36
      'SCNetworkReachabilitySetDispatchQueue' was deprecated in iOS 17.4
  brainwallet/ReachabilityMonitor.swift:41
      'SCNetworkReachabilityGetFlags' was deprecated in iOS 17.4
  brainwallet/New Send Classes/Send Views/BentoSendViews/BentoSendModalView.swift:113
      Initialization of immutable value 'height' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Game Classes/EmojiView.swift:29
      Initialization of immutable value 'factoredSize' was never used; consider replacing with assignment to '_' or removing it
  Modules/core/BRPeerManager.c:836
      Unused variable 'ts'
  brainwallet/PaymentProtocol.swift:187
      'SecKeyRawVerify' was deprecated in iOS 15.0: Use SecKeyVerifySignature
  Modules/core/BRPeerManager.c:786
      Unused function '_BRPeerManagerFindPeers'
  brainwallet/Extensions/Extensions.swift:58
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/PaymentProtocol.swift:141
      Initialization of 'UnsafeMutablePointer' results in a dangling pointer
  brainwallet/Legacy_BW_BRClasses/BRReplicatedKVStore.swift:742
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/WalletManager.swift:310
      Initialization of 'UnsafePointer' results in a dangling pointer
  brainwallet/Additions/String+Additions.swift:91
      'init(bytes:)' is deprecated: use `init(_:)` instead
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:45
      Initialization of 'UnsafeRawPointer' results in a dangling pointer
  Modules/core/BRPeerManager.c:838
      Unused variable 'attr'
  brainwallet/WalletManager+Auth.swift:622
      'unarchiveObject(with:)' was deprecated in iOS 12.0: Use +unarchivedObjectOfClass:fromData:error: instead
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:20
      Initialization of 'UnsafeMutableRawPointer' results in a dangling pointer
  brainwallet/WalletManager+Auth.swift:647
      'archivedData(withRootObject:)' was deprecated in iOS 12.0: Use +archivedDataWithRootObject:requiringSecureCoding:error: instead
  brainwallet/Extensions/Extensions.swift:191
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:245
      Initialization of 'UnsafePointer' results in a dangling pointer
  brainwallet/Extensions/Extensions.swift:179
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/WalletManager+Auth.swift:620
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/ModalTransitionDelegate.swift:82
      'windows' was deprecated in iOS 15.0: Use UIWindowScene.windows on a relevant window scene instead
  brainwallet/Bento Effects /BentoBackgroundHelpers.swift:201
      Initialization of immutable value 'width' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/WalletManager+Auth.swift:462
      No calls to throwing functions occur within 'try' expression
  brainwallet/New Send Classes/Send Views/BentoSendViews/BentoSendConfirmView.swift:115
      Variable 'transactionError' was written to, but never read
  brainwallet/PaymentProtocol.swift:189
      'SecKeyRawVerify' was deprecated in iOS 15.0: Use SecKeyVerifySignature
  brainwallet/New Main Classes/NewMainView.swift:125
      Initialization of immutable value 'width' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Extensions/Extensions.swift:277
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/BWAPIClient Classes/BWAPIClient+FiatLTCRates.swift:89
      Function call causes an infinite recursion
  Private/general-purpose/BrainwalletiOSPrivateGeneralPurpose/PDFHelper/PDFConstructedView.swift:78
      Initialization of immutable value 'height' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Extensions/Extensions.swift:209
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/UIView+FrameChangeBlocking.swift:10
      Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
  brainwallet/PaymentProtocol.swift:163
      'SecTrustEvaluate' was deprecated in iOS 13.0: renamed to 'SecTrustEvaluateWithError(_:_:)'
  brainwallet/Extensions/Extensions.swift:43
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  Modules/core/BRPeerManager.c:839
      Unused variable 'addrList'
  brainwallet/Bento Views/Game Hub Bentos/MoonPayView.swift:33
      Initialization of immutable value 'labelBackground' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Signup Notification Classes/SignupAskView.swift:49
      Initialization of immutable value 'width' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Extensions/Extensions.swift:200
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:52
      Initialization of 'UnsafeRawPointer' results in a dangling pointer
  brainwallet/Extensions/Extensions.swift:218
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Legacy_BW_BRClasses/BRReplicatedKVStore.swift:791
      Initialization of 'UnsafePointer' results in a dangling pointer
  brainwallet/ModalPresenter+Extension.swift:60
      'windows' was deprecated in iOS 15.0: Use UIWindowScene.windows on a relevant window scene instead
  brainwallet/Extensions/Extensions.swift:275
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:178
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/WalletCoordinator.swift:175
      Weak variable 'myself' was never mutated; consider changing to 'let' constant
  brainwallet/Legacy_BW_BRClasses/BRReplicatedKVStore.swift:603
      Treating a forced downcast to 'BRReplicatedKVStoreError' as optional will never produce 'nil'
  brainwallet/PaymentProtocol.swift:155
      'init(bytes:)' is deprecated: use `init(_:)` instead
  brainwallet/WalletManager.swift:522
      'SCNetworkReachabilityCreateWithAddress' was deprecated in iOS 17.4
  brainwallet/ModalPresenter.swift:107
      'windows' was deprecated in iOS 15.0: Use UIWindowScene.windows on a relevant window scene instead
  brainwallet/New Send Classes/Send Views/BentoSendViews/BentoSendInitialView.swift:382
      Result of call to 'isSendInformationValid()' is unused
  brainwallet/Extensions/Extensions.swift:224
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  Modules/core/BRPeerManager.c:840
      Unused variable 'info'
  brainwallet/UIView+FrameChangeBlocking.swift:15
      Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:55
      'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'BRAddress' to 'Hashable' by implementing 'hash(into:)' instead
  brainwallet/Additions/UIButton+BRWAdditions.swift:10
      Immutable value 'spacing' was never used; consider replacing with '_' or removing it
   command not found - See https://github.com/realm/SwiftLint#installation for installation instructions.
  brainwallet/WalletManager+Auth.swift:386
      Initialization of 'UnsafeMutableRawPointer' results in a dangling pointer
  brainwallet/PaymentProtocol.swift:132
      Initialization of 'UnsafeMutablePointer' results in a dangling pointer
  Modules/core/BRPeerManager.c:839
      Unused variable 'addr'
  brainwallet/Legacy_BW_BRClasses/BRTxOutputExtension.swift:8
      Initialization of 'UnsafeRawPointer' results in a dangling pointer
  brainwallet/Extensions/Extensions.swift:169
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:227
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/WalletManager+Auth.swift:641
      Treating a forced downcast to 'CFString' as optional will never produce 'nil'
  brainwallet/New Send Classes/Send Views/BentoSendViews/BentoSendModalView.swift:112
      Initialization of immutable value 'width' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/WalletManager.swift:523
      'SCNetworkReachabilityGetFlags' was deprecated in iOS 17.4
  brainwallet/Legacy_BW_BRClasses/BRAddressExtension.swift:28
      Initialization of 'UnsafeMutableRawPointer' results in a dangling pointer
  brainwallet/PaymentProtocol.swift:170
      'SecTrustCopyProperties' was deprecated in iOS 15.0: renamed to 'SecTrustEvaluateWithError(_:_:)'
  brainwallet/Extensions/Extensions.swift:159
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:152
      Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
  brainwallet/WalletManager+Auth.swift:78
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/ReachabilityMonitor.swift:12
      'SCNetworkReachabilityCreateWithName' was deprecated in iOS 17.4
  brainwallet/Bento Views/Game Hub Bentos/MoonPayView.swift:34
      Initialization of immutable value 'labelForeground' was never used; consider replacing with assignment to '_' or removing it
  brainwallet/Extensions/Extensions.swift:44
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/BundleExtension.swift:5
      Class 'BundleEx' must restate inherited '@unchecked Sendable' conformance
  brainwallet/Extensions/Extensions.swift:386
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Extensions/Extensions.swift:148
      Forming 'UnsafeRawPointer' to an inout variable of type String exposes the internal representation rather than the string contents.
  brainwallet/Legacy_BW_BRClasses/BRTxInputExtension.swift:6
      Initialization of 'UnsafeRawPointer' results in a dangling pointer
  brainwallet/Extensions/Extensions.swift:276
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  brainwallet/Legacy_BW_BRClasses/BRKeyExtension.swift:62
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead