Repository navigation
Serve HTTPS for hostnames more than one label under grov.site - #40
Merged
Merged
Conversation
- Sign a leaf per routed hostname, so names like app.capella.grov.site validate - Give unrouted names the shared wildcard, so tailnet peers can't force a signature per invented name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wildcard certificate covers exactly one label, which is what keeps every context at
<context>.grov.site. Tailnet mode will want names likeapp.capella.grov.site, one per host, and DNS already resolves names that deep. This change lets the certificates follow.*.grov.siteleaf. Once the daemon answers on the tailnet, any peer can offer any hostname, so only names the proxy routes may cost a signature.Testing
go test -race -count=1 ./...,go vet ./...,gofmt -l .The docs' HTTPS page and the README pitch no longer describe a single wildcard certificate.