Repository navigation
Show the nothing-bound page for a sharing machine's stopped contexts - #44
Merged
Merged
Conversation
- Unrouted names under the zone get the zone's own wildcard, since the domain's covers only one label and every shared name sits two deep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a machine that shares (#41), a context that isn't running showed a certificate error where grove means to show its "nothing bound" page.
Why
An unrouted name gets a shared wildcard instead of a leaf of its own, so made-up names can't make the daemon sign one apiece (#40). That wildcard was always
*.grov.site, which covers exactly one label. Sharing puts every hostname two labels deep,<context>.<host>.grov.site, so the wildcard covered none of them. After a reboot ended a stack's leases, a phone opening its URL saw a certificate for the wrong name and called it untrusted.Change
*.<host>.grov.site. One-label names still get*.grov.site.Testing
go test -race -count=1 ./...,go vet ./...,gofmt -l ., and the docs link check.nothing-here.regulus.grov.sitenow serves*.regulus.grov.siteand the 503 page, verified against the machine's root, while a routed name still gets its own leaf.