Mock proof verify fix - #124
Open
SamAg19 wants to merge 2 commits into
Open
Conversation
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem being Addressed
The fork-choice spec-test fixtures ship mocked aggregate proofs (the
MOCKED-AGGREGATION-PROOFsentinel), but the test driver ran the real XMSS verify on them and rejected every one, causing 27lean-spec-tests-fork-choicehive tests to fail.Solution
This PR adds a
verify_proofgate toon_aggregated_attestationand had the driver skip the SNARK only when it detects the mock sentinel. Real proofs are still verified by the tests, and production always passestruetoon_aggregated_attestation.