Repository navigation
fix(display): preserve stage aspect ratio and project-colored letterboxing - #1927
Merged
Merged
Conversation
Parent: dev@8b3790203aee Merge-Order: 06/23
Parent: dev@8b3790203aee Merge-Order: 05/23
Parent: dev@8b3790203aee Merge-Order: 02/23
Parent: refactor/godot-audio-ownership@74c2e1716150 Merge-Order: 04/23
Parent: dev@8b3790203aee Merge-Order: 03/23
Parent: dev@8b3790203aee Merge-Order: 01/23
Parent: dev@8b3790203aee Merge-Order: 07/23
Parent: refactor/godot-integrated@d95c95ff0869 Merge-Order: 09/23
Parent: dev@8b3790203aee Merge-Order: 08/23
Parent: refactor/godot-integrated@d95c95ff0869 Merge-Order: 21/23
Parent: dev@8b3790203aee Merge-Order: 20/23
Parent: dev@8b3790203aee Merge-Order: 19/23
Parent: dev@8b3790203aee Merge-Order: 18/23
Parent: refactor/godot-audio-ownership@74c2e1716150 Merge-Order: 17/23
Parent: dev@8b3790203aee Merge-Order: 16/23
Parent: dev@8b3790203aee Merge-Order: 15/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 14/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 13/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 12/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 11/23
Parent: dev@8b3790203aee Merge-Order: 10/23
Parent: dev@8b3790203aee Merge-Order: 22/23
Parent: refactor/godot-integrated@45fa2090c033 Merge-Order: 23/23
songweijun1203
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the fitted logical content size from the Web host canvas and replace three stretch bindings with one SetStretch call. Use KEEP for Native and Web without an intermediate IGNORE toggle, so resize preserves stage proportions and camera/input coordinates. Pin the matching Godot letterbox-color fix in a new, unpublished runtime 3.0.1 candidate without changing the published 3.0.0 snapshot.
Parent:
refactor/godot-integratedat 45fa2090c033. Dependency-stage merge order: 23/23.This draft targets
dev, so its GitHub diff includes prerequisite changes. The parent SHA above pins the historical review baseline; the current parent branch may already contain this topic. Topic-only diff. Merge after #1925 and the matching engine change goplus/godot#336.Prior integrated validation: Matching Native/Web builds, generation and relevant Go/Node tests passed. Window-order comparisons covered 576 combinations; Web DPR 1/2 resize checks kept the same visible world and white margins. Native OpenGL/Metal color checks passed. One initial Stop/Start run logged a destroy_sprite warning; an unchanged headless rerun passed, so this PR does not claim to fix that separate cleanup warning. The current update only shortens commit messages; all source trees match the validated history. Validation record. Current diff check also reports an existing extra EOF blank line in the Web ABI test stub.