Repository navigation
refactor(godot): integrate and simplify the Godot module implementation - #1925
Conversation
Parent: dev@8b3790203aee Merge-Order: 06/23
Parent: dev@8b3790203aee Merge-Order: 05/23
Parent: dev@8b3790203aee Merge-Order: 02/23
Parent: refactor/godot-audio-ownership@74c2e1716150 Merge-Order: 04/23
Parent: dev@8b3790203aee Merge-Order: 03/23
Parent: dev@8b3790203aee Merge-Order: 01/23
Parent: dev@8b3790203aee Merge-Order: 07/23
Parent: refactor/godot-integrated@d95c95ff0869 Merge-Order: 09/23
Parent: dev@8b3790203aee Merge-Order: 08/23
Parent: refactor/godot-integrated@d95c95ff0869 Merge-Order: 21/23
Parent: dev@8b3790203aee Merge-Order: 20/23
Parent: dev@8b3790203aee Merge-Order: 19/23
Parent: dev@8b3790203aee Merge-Order: 18/23
Parent: refactor/godot-audio-ownership@74c2e1716150 Merge-Order: 17/23
Parent: dev@8b3790203aee Merge-Order: 16/23
Parent: dev@8b3790203aee Merge-Order: 15/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 14/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 13/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 12/23
Parent: refactor/godot-integrated@1e452f6cc2a1 Merge-Order: 11/23
Parent: dev@8b3790203aee Merge-Order: 10/23
Parent: dev@8b3790203aee Merge-Order: 22/23
There was a problem hiding this comment.
Reviewed the complete fixed range from 8b3790203aee3cb713dc1a01b91f583d926830b8 through 45fa2090c033d6852e1b3eec631712e3a0dbb3e3, covering the lifecycle, ownership, resource, binding, sprite, ZIP, build-tool, and code-generation changes. I found no PR-introduced correctness or regression issue that meets the review threshold.
Validation passed for go test ./fs/zip, the code-generation module tests, binding/runtime packages, go test ./... outside the unrelated existing internal/projectpolicy failure, bash godot_modules/spx/tests/run_abi_test.sh, and node --test godot_modules/spx/web/tests/native_array.test.cjs. git diff --check reports only the documented extra blank line at EOF in godot_modules/spx/web/tests/stubs/godot_types.h.
Integrate the lifecycle, ownership, resource, binding and sprite refactors for Native and normal Web. The final cleanup passes GdObj/GdInt inputs by value with generator-managed BigInt conversion, shares texture/font preparation, removes mirrored Wasm-export caches, and deletes production hooks used only by tests. Recording and Worker modes are outside this change.
Parent:
devat 8b3790203aee. Dependency-stage merge order: 07/23, 10/23, 22/23.This is the combined delivery PR for the topic reviews below. Merging it includes their changes.
refactor/godot-lifecycle-controlsfix/godot-web-session-lifetimerefactor/godot-audio-ownershiprefactor/godot-object-accessrefactor/godot-visual-resourcesrefactor/godot-abi-boundariesrefactor/godot-bindings-simplerefactor/godot-resource-lifetimesrefactor/godot-sprite-algorithmsrefactor/godot-manager-lifecycleperf/godot-web-scalarsPrior integrated validation: make generate and matching Native/normal Web builds passed; 72 Native cases (639 assertions), codegen tests, 33 Node tests, js/wasm bindings and standalone ABI/UBSan checks passed. 05-Animation ran in Native and Web with animation, input and restart checks. The separate letterbox branch fixes the known host/content-size layout issue. The current update only shortens commit messages; all source trees match the validated history. Validation record. Current diff check also reports an existing extra EOF blank line in the Web ABI test stub.
Related PRs: the same-head alias is #1926; stage letterboxing follows in #1927 with engine support from goplus/godot#336.