Repository navigation
Add impurity_right_bc to EdgeModelOutputs and decouple _update_impurities from Extended Lengyel. - #2474
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_982421473
branch
3 times, most recently
from
September 28, 2026 11:41
deeb623 to
379b3e8
Compare
…ties from Extended Lengyel. Updating core impurity boundary conditions previously required `updaters.py` to inspect Extended Lengyel enums and recalculate enrichment scaling factors, preventing generic substitution with alternative edge models. Add `impurity_right_bc` to `EdgeModelOutputs` in `torax/_src/edge/base.py`. Compute boundary conditions directly within `_build_extended_lengyel_outputs` for seeded impurities and edge-sourced fixed impurities. Simplify `_update_impurities` in `updaters.py` to consume `edge_outputs.impurity_right_bc` directly, removing model-specific scaling factor calculations. PiperOrigin-RevId: 989560797
copybara-service
Bot
force-pushed
the
test_982421473
branch
from
September 28, 2026 11:54
379b3e8 to
2e6fb6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add impurity_right_bc to EdgeModelOutputs and decouple _update_impurities from Extended Lengyel.
Updating core impurity boundary conditions previously required
updaters.pyto inspect Extended Lengyel enums and recalculate enrichment scaling factors, preventing generic substitution with alternative edge models.Add
impurity_right_bctoEdgeModelOutputsintorax/_src/edge/base.py. Compute boundary conditions directly within_build_extended_lengyel_outputsfor seeded impurities and edge-sourced fixed impurities. Simplify_update_impuritiesinupdaters.pyto consumeedge_outputs.impurity_right_bcdirectly, removing model-specific scaling factor calculations.