Repository navigation
Decouple enrichment factor updates from updaters into ExtendedLengyelModel. - #2473
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_983428291
branch
2 times, most recently
from
September 28, 2026 11:27
aa14448 to
bd41226
Compare
…Model. When using the enrichment model with core-sourced fixed impurities, `updaters.py` previously mutated `runtime_params.edge.enrichment_factor`. This coupled general runtime parameter updating to Extended Lengyel internal state mechanics. Calculate edge fixed impurity concentrations directly in `ExtendedLengyelModel` using `previous_edge_outputs.calculated_enrichment`, falling back to configured runtime parameters when previous outputs are absent. Remove `_update_enrichment_factor` and its corresponding test from `updaters.py`. PiperOrigin-RevId: 989556318
copybara-service
Bot
force-pushed
the
test_983428291
branch
from
September 28, 2026 11:41
bd41226 to
aa3e2f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple enrichment factor updates from updaters into ExtendedLengyelModel.
When using the enrichment model with core-sourced fixed impurities,
updaters.pypreviously mutatedruntime_params.edge.enrichment_factor. This coupled general runtime parameter updating to Extended Lengyel internal state mechanics.Calculate edge fixed impurity concentrations directly in
ExtendedLengyelModelusingprevious_edge_outputs.calculated_enrichment, falling back to configured runtime parameters when previous outputs are absent. Remove_update_enrichment_factorand its corresponding test fromupdaters.py.