Skip to content

Add Pylint workflow for Python code analysis - #2449

Open
nexoracontrol-ops wants to merge 1 commit into
google-deepmind:mainfrom
nexoracontrol-ops:main
Open

nexoracontrol-ops wants to merge 1 commit into
google-deepmind:mainfrom
nexoracontrol-ops:main

Conversation

@nexoracontrol-ops

@nexoracontrol-ops nexoracontrol-ops commented Sep 10, 2026 •

Copy link
Copy Markdown

content/actions/how-tos/manage-workflow-runs/approve-runs-from-forks.md

@google-cla

google-cla Bot commented Sep 10, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nexoracontrol-ops
nexoracontrol-ops marked this pull request as ready for review September 10, 2026 11:33

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow cannot successfully lint the current TORAX tree as written. The project declares requires-python = ">=3.12", but the matrix only runs 3.8–3.10, and the job installs only pylint, not TORAX or its dependencies. That means the proposed check targets unsupported interpreters and will also emit import errors for normal imports such as JAX/Flax rather than useful project diagnostics. Could the matrix use the supported Python versions and install the project/dev extra before invoking pylint (for example, pip install -e '.[dev]')?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants