Switch to using scaled RMS and Linfinity norms in the linesearch and convergence check respectively. - #2439
Open
copybara-service[bot] wants to merge 1 commit into
Open
Switch to using scaled RMS and Linfinity norms in the linesearch and convergence check respectively.#2439copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_977791309
branch
2 times, most recently
from
September 11, 2026 19:09
c30c928 to
ecdef3a
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_977791309
branch
from
September 25, 2026 13:58
ecdef3a to
206323c
Compare
copybara-service
Bot
changed the title
…convergence check respectively. This matches what is done in industry-standard PDE solvers. Previously we were using unscaled L1 norm, which has worse convergence properties. Note that the linesearch norm is a root-mean-square (RMS) norm rather than a strict L2 norm due to normalization by the number of cells. Most tests unchanged or changed by <O(1e-6). Tests with particularly difficult transients (e.g. LH transition with adaptive transport, radiation collapse) were changed by up to O(1e-1), but qualitative behaviour remains unchanged. PiperOrigin-RevId: 977791309
copybara-service
Bot
force-pushed
the
test_977791309
branch
from
September 28, 2026 07:25
206323c to
7d612ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using scaled RMS and Linfinity norms in the linesearch and convergence check respectively.
This matches what is done in industry-standard PDE solvers. Previously we were using unscaled L1 norm, which has worse convergence properties. Note that the linesearch norm is a root-mean-square (RMS) norm rather than a strict L2 norm due to normalization by the number of cells.
Most tests unchanged or changed by <O(1e-6). Tests with particularly difficult transients (e.g. LH transition with adaptive transport, radiation collapse) were changed by up to O(1e-1), but qualitative behaviour remains unchanged.