Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions rust/ql/lib/codeql/rust/internal/PathResolution.qll
Original file line number Diff line number Diff line change
Expand Up @@ -194,21 +194,11 @@ abstract class ItemNode extends Locatable {
this = result.(ImplOrTraitItemNode).getAnItemInSelfScope()
or
name = "crate" and
result =
any(CrateItemNode crate |
this = crate.getASourceFile()
or
this = crate.getModuleNode()
)
this = result.(CrateItemNode).getARootModuleNode()
or
// todo: implement properly
name = "$crate" and
result =
any(CrateItemNode crate |
this = crate.getASourceFile()
or
this = crate.getModuleNode()
).(Crate).getADependency*() and
result = any(CrateItemNode crate | this = crate.getARootModuleNode()).(Crate).getADependency*() and
result.(CrateItemNode).isPotentialDollarCrateTarget()
}

Expand Down Expand Up @@ -237,7 +227,7 @@ abstract private class ModuleLikeNode extends ItemNode {
predicate isRoot() {
this instanceof SourceFileItemNode
or
this = any(CrateItemNode c).getModuleNode()
this = any(Crate c).getModule()
}
}

Expand Down Expand Up @@ -294,6 +284,15 @@ class CrateItemNode extends ItemNode instanceof Crate {
)
}

/**
* Gets a root module node belonging to this crate.
*/
ModuleLikeNode getARootModuleNode() {
result = this.getASourceFile()
or
result = super.getModule()
}

pragma[nomagic]
predicate isPotentialDollarCrateTarget() {
exists(string name, RelevantPath p |
Expand Down