Skip to content

Rust: Minor path resolution fix for ($)crate paths#19220

Merged
hvitved merged 1 commit intogithub:mainfrom
hvitved:rust/path-resolution-crate-fix
Apr 7, 2025
Merged

Rust: Minor path resolution fix for ($)crate paths#19220
hvitved merged 1 commit intogithub:mainfrom
hvitved:rust/path-resolution-crate-fix

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Apr 4, 2025

Only matters to rust-lang/rust, where the prelude exists in both source code and in the crate graph, so we need to handle both.

@github-actions github-actions Bot added the Rust Pull requests that update Rust code label Apr 4, 2025
@hvitved hvitved marked this pull request as ready for review April 7, 2025 07:33
Copilot AI review requested due to automatic review settings April 7, 2025 07:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@hvitved hvitved requested a review from paldepind April 7, 2025 07:34
@hvitved hvitved merged commit ca5cc8e into github:main Apr 7, 2025
16 checks passed
@hvitved hvitved deleted the rust/path-resolution-crate-fix branch April 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants