ggml-cpu(s390x): guard VXE-only repack helpers - #28775
Merged
taronaeo merged 1 commit intoSep 13, 2026
Merged
Conversation
taronaeo
approved these changes
Sep 11, 2026
taronaeo
added
the
merge ready
github-actions
Bot
added
the
ggml
This was referenced Sep 13, 2026
taronaeo
added a commit
to taronaeo/llama.cpp-s390x
that referenced
this pull request
Sep 13, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
CISC
approved these changes
Sep 13, 2026
taronaeo
added a commit
to taronaeo/llama.cpp-s390x
that referenced
this pull request
Sep 13, 2026
This reverts commit d464525. Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
taronaeo
added a commit
to taronaeo/llama.cpp-s390x
that referenced
this pull request
Sep 13, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> ggml-cpu: add unused macro to fix ci Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Revert "ggml-cpu: temporarily add ggml-org#28775 patch until its merged" This reverts commit d464525. Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On s390x without VXE/VXE2, the repack helpers
vxe_dot_acc,vxe_splat_granuleandvxe_foldare still compiled even though their vector intrinsics are unavailable, breaking the build.This wraps the three helpers in the same
#if defined(__VXE__) || defined(__VXE2__)guard as their call sites.Additional information
Reported in #28667, ; @taronaeo confirmed the missing guards there.
Requirements