tests(s390x): add non-vxe build to tests - #28776
Open
taronaeo wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
devops
taronaeo
force-pushed
the
ci/s390x-non-vxe
branch
from
September 13, 2026 13:44
eb1ef3b to
838329e
Compare
github-actions
Bot
added
the
ggml
Member
Author
|
Okay s390x CIs are green now but #28775 is not approved yet to move this forward :( Edit: Yay we're almost there |
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> ggml-cpu: add unused macro to fix ci Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Revert "ggml-cpu: temporarily add ggml-org#28775 patch until its merged" This reverts commit d464525. Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
taronaeo
force-pushed
the
ci/s390x-non-vxe
branch
from
September 13, 2026 17:20
5da27d1 to
390879d
Compare
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
taronaeo
added
the
merge ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #28667
Additional information
Although we write code mainly for
-DGGML_VXE=ON, there are instances where vector intrinsic is not compiled in. Our current CI setup does not catch bugs for-DGGML_VXE=OFFand this PR fixes that by adding another test in the matrix to compile and catch these problems early.Requirements