Repository navigation
chore(deps): bump gocloud.dev from v0.29.0 to v0.46.0 - #721
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d41b87d. Configure here.
mjq
marked this pull request as ready for review
October 9, 2026 14:52
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
DominikB2014
approved these changes
Oct 9, 2026
aldy505
added a commit
to getsentry/self-hosted
that referenced
this pull request
Oct 12, 2026
Upgraded on getsentry/vroom#721, this causes failing e2e tests Confirmed by reading this: https://pkg.go.dev/gocloud.dev/blob/s3blob?utm_source=godoc#URLOpener, which refers to https://github.com/google/go-cloud/blob/b77c6be2700b2401d3645a7c313b4b848dc54e67/blob/s3blob/s3blob.go#L132-L139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gocloud.devabstracts over various cloud storage. Upgrading it also upgrades underlying S3 libraries, which obsoletes the failing dependabot PR #685 and fixes #661.Upgrading the library got us a couple small simplifications:
BeforeWritefunction with the new&blob.WriterOptions{IfNotExist: true}gcerrors.Code(err) == gcerrors.NotFound || errors.Is(err, storage.ErrObjectNotExist)witherrors.Is(err, gcerrors.ErrNotFound)But now we do need an extra error check to distinguish between underlying 403s and 404s, since newer versions of
gocloud.devreport them both as 404.Fixes PRO-52.