Skip to content

fix(vroom): breaking change on SENTRY_BUCKET_PROFILES - #4555

Merged
aldy505 merged 3 commits into
masterfrom
aldy505/fix/vroom/breaking-change-profiles-url-params
Oct 12, 2026
Merged

aldy505 merged 3 commits into
masterfrom
aldy505/fix/vroom/breaking-change-profiles-url-params

Conversation

@aldy505

@aldy505 aldy505 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c668c86. Configure here.

Comment thread docker-compose.yml
Comment thread docker-compose.yml
SENTRY_KAFKA_BROKERS_PROFILING: "kafka:9092"
SENTRY_KAFKA_BROKERS_OCCURRENCES: "kafka:9092"
SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&s3ForcePathStyle=true&disableSSL=true"
SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&use_path_style=true&disable_https=true"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale external-kafka compose patch

Low Severity

The external-kafka compose patch still uses the old SENTRY_BUCKET_PROFILES context line. After this change that hunk no longer matches, so patch -p0 will fail for anyone applying the optional modification.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c668c86. Configure here.

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking

sentry-junior Bot and others added 2 commits October 12, 2026 01:25
Co-Authored-By: Reinaldy Rafli <work@reinaldyrafli.com>
Co-Authored-By: Reinaldy Rafli <work@reinaldyrafli.com>
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 38s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (5 of 5 changed executable lines covered; target 50%).
Project statement coverage is 95.58% (up 0.05 percentage points from base (b018620) to head (6c03209)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
_integration-test/test_01_basics.py 100.00% 5/5 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #4555       +/-##
==========================================
+ Coverage    95.53%    95.58%    +0.05%
==========================================
  Files            5         5         —
  Tracked lines       335       339        +4
  Branches         0         0         —
==========================================
+ Hits           320       324        +4
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@aldy505
aldy505 merged commit e29cfe0 into master Oct 12, 2026
22 checks passed
@aldy505
aldy505 deleted the aldy505/fix/vroom/breaking-change-profiles-url-params branch October 12, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants