Repository navigation
fix(vroom): breaking change on SENTRY_BUCKET_PROFILES - #4555
Conversation
Upgraded on getsentry/vroom#721, this causes failing e2e tests Confirmed by reading this: https://pkg.go.dev/gocloud.dev/blob/s3blob?utm_source=godoc#URLOpener, which refers to https://github.com/google/go-cloud/blob/b77c6be2700b2401d3645a7c313b4b848dc54e67/blob/s3blob/s3blob.go#L132-L139
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c668c86. Configure here.
| SENTRY_KAFKA_BROKERS_PROFILING: "kafka:9092" | ||
| SENTRY_KAFKA_BROKERS_OCCURRENCES: "kafka:9092" | ||
| SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&s3ForcePathStyle=true&disableSSL=true" | ||
| SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&use_path_style=true&disable_https=true" |
There was a problem hiding this comment.
Stale external-kafka compose patch
Low Severity
The external-kafka compose patch still uses the old SENTRY_BUCKET_PROFILES context line. After this change that hunk no longer matches, so patch -p0 will fail for anyone applying the optional modification.
Reviewed by Cursor Bugbot for commit c668c86. Configure here.
Co-Authored-By: Reinaldy Rafli <work@reinaldyrafli.com>
Co-Authored-By: Reinaldy Rafli <work@reinaldyrafli.com>
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 38s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (5 of 5 changed executable lines covered; target 50%). Changed files with executable lines (1)
Coverage diff@@ Coverage Diff @@
## master #4555 +/-##
==========================================
+ Coverage 95.53% 95.58% +0.05%
==========================================
Files 5 5 —
Tracked lines 335 339 +4
Branches 0 0 —
==========================================
+ Hits 320 324 +4
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |


Upgraded on getsentry/vroom#721, this causes failing e2e tests
Confirmed by reading this: https://pkg.go.dev/gocloud.dev/blob/s3blob?utm_source=godoc#URLOpener, which refers to https://github.com/google/go-cloud/blob/b77c6be2700b2401d3645a7c313b4b848dc54e67/blob/s3blob/s3blob.go#L132-L139