Skip to content

fix(msteams): fail on a missing conversation id - #129427

Draft
joshuarli wants to merge 1 commit into
getsentry:masterfrom
joshuarli:fix/msteams-conversation-id
Draft

joshuarli wants to merge 1 commit into
getsentry:masterfrom
joshuarli:fix/msteams-conversation-id

Conversation

@joshuarli

@joshuarli joshuarli commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Behavioral split from #129431.

The Teams conversations API response must contain an id. Index the response so a malformed payload raises KeyError instead of returning None and building an activity URL containing None.

Tests cover both the normal response and the missing-id case.

The conversations API response must carry an id. Index the response so a
malformed payload raises instead of returning None and building an
activity URL containing "None".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant