Repository navigation
Conversation
Rebuild the accepted typing campaign on current master as an annotation-only change. Excludes the campaign evaluator, its policy modules, the campaign log, and owner-owned baseline edits. Behavior changes are carved into separate PRs; this commit preserves runtime behavior, including ReleaseFile.save positional compatibility and the release serializer's existing stats and newGroups output. Fix two refactor regressions: starred group search views keep their createdBy/starred/stars fields, and Seer commit lookups stay keyed by primary key instead of sha. Allow the weaklist guard to accept narrowing a wildcard into named modules, which is how the flags endpoints wildcard graduates.
joshuarli
force-pushed
the
typing-hillclimb-upstream
branch
from
October 31, 2026 16:52
eb7d115 to
0cafdc5
Compare
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This was referenced Oct 31, 2026
Member
Author
|
Superseded by #129431. GitHub keeps a fork PR pinned to its original head branch, so the rebuilt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types the serializer, endpoint, model, and integration surface with precise contracts (TypedDict responses, narrowed users, IO/QuerySet generics, Mapping over schemaless JSON) and graduates the covered modules out of the mypy weaklist, including narrowing the
sentry.flags.endpoints.*wildcard to the two modules that still need leniency.This branch was rebuilt on current master as an annotation-only change:
ReleaseFile.saveruntime contract (the earlier keyword-only signature change is dropped) and uses casts where the campaign had added fail-closed assertions, so runtime behavior is unchanged.createdBy/starred/stars, and Seer commit lookups stay keyed by primary key instead of sha.Behavioral changes are split into separate draft PRs (none stacked):
typing-hillclimb-campaignis the canonical integration branch, renamed fromtyping-hillclimb-upstream; this PR points at its rebuilt commit.Verification on the rebuilt tree: mypy clean over all 249 changed Python files, ruff check/format clean over changed files, and focused pytest suites for release serialization, the starred search-view endpoint, Teams client, release files, Seer tools, options store, paginator, Jira search, apidocs extensions, Bitbucket client, and metrics query builder.