Skip to content

fix(vroom): breaking change on SENTRY_BUCKET_PROFILES #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldy505 merged 3 commits into from
Oct 12, 2026
Merged

fix(vroom): breaking change on SENTRY_BUCKET_PROFILES #4555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c668c86
fix(vroom): breaking change on SENTRY_BUCKET_PROFILES
aldy505 Oct 10, 2026
763d921
fix(tests): Log in through the auth API in integration tests
sentry-junior[bot] Oct 12, 2026
6c03209
fix(tests): Fetch auth config before API login to set test cookie
sentry-junior[bot] Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions _integration-test/test_01_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,28 @@ def authenticated_session():
client = httpx.Client()
client.get(SENTRY_TEST_HOST, follow_redirects=True)
login_csrf_token = client.cookies["sc"]
login_response = client.post(
f"{SENTRY_TEST_HOST}/auth/login/sentry/",
follow_redirects=True,
data={
"op": "login",
"username": TEST_USER,
"password": TEST_PASS,
"csrfmiddlewaretoken": login_csrf_token,
# Password login goes through the auth API used by the React login page;
# the legacy HTML login form was removed in getsentry/sentry#126712.
# Like the React page, fetch the auth config first: it sets the session
# test cookie that the login endpoint requires.
auth_config_response = client.get(
f"{SENTRY_TEST_HOST}/api/0/auth/config/",
headers={"Referer": f"{SENTRY_TEST_HOST}/auth/login/"},
)
assert auth_config_response.status_code == 200, auth_config_response.text
api_login_response = client.post(
f"{SENTRY_TEST_HOST}/api/0/auth/login/",
json={"username": TEST_USER, "password": TEST_PASS},
headers={
"Referer": f"{SENTRY_TEST_HOST}/auth/login/",
"X-CSRFToken": login_csrf_token,
},
headers={"Referer": f"{SENTRY_TEST_HOST}/auth/login/sentry/"},
)
assert api_login_response.status_code == 200, api_login_response.text
login_response = client.get(
SENTRY_TEST_HOST,
follow_redirects=True,
headers={"Referer": SENTRY_TEST_HOST},
)
assert login_response.status_code == 200
parser = BeautifulSoup(login_response.text, "html.parser")
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ services:
environment:
SENTRY_KAFKA_BROKERS_PROFILING: "kafka:9092"
SENTRY_KAFKA_BROKERS_OCCURRENCES: "kafka:9092"
SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&s3ForcePathStyle=true&disableSSL=true"
SENTRY_BUCKET_PROFILES: "s3://profiles?region=us-east-1&endpoint=seaweedfs:8333&use_path_style=true&disable_https=true"
Comment thread
aldy505 marked this conversation as resolved.

@cursor cursor Bot Oct 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale external-kafka compose patch

Low Severity

The external-kafka compose patch still uses the old SENTRY_BUCKET_PROFILES context line. After this change that hunk no longer matches, so patch -p0 will fail for anyone applying the optional modification.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c668c86. Configure here.

AWS_ACCESS_KEY: "sentry"
AWS_SECRET_KEY: "sentry"
SENTRY_SNUBA_HOST: "http://snuba-api:1218"
Expand Down
Loading