Repository navigation
fix: Scope publish approvals to target repositories - #9693
Merged
Merged
Conversation
Jeffreyhung
approved these changes
Oct 1, 2026
This was referenced Oct 5, 2026
BYK
pushed a commit
that referenced
this pull request
Oct 6, 2026
#9693 rejects `accepted` labels from every `[bot]` account except `sentry-internal-app[bot]`. That broke Junior's release flow: on #9771, `sentry-junior[bot]` added `accepted` and the workflow removed it, so a human had to approve the release by hand. This adds an allowlist of trusted Sentry-operated release bots, which can approve any valid getsentry publish target. For now `sentry-junior[bot]` is the only entry. Other bots are still rejected, and malformed repos or publish paths still fail before the allowlist is checked. The rest of #9693 stays as-is: per-target authorization for humans, revalidation before `ci-ready`, and revoking stranded labels. Every approval check (`publish.yml` and `ci-poller.yml`) goes through `authorizeApproval`, so all of them pick up the allowlist. Refs #9772 <!-- junior-request-attribution:start --> via **David Cramer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AG6MCDB51U%3A1791237467.400049 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AG6MCDB51U%3A1791237467.400049) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AG6MCDB51U%3A1791237467.400049/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptedtransition against the exact target repository and publish pathci-readyand target checkoutaccepted,ci-pending, andci-readystate with verified retriesTest plan
yarn test --printConsoleTrace(17 files, 125 tests)yarn lintyamlpackagegit diff --checkFixes #9355