Repository navigation
feat: Allow sentry-junior[bot] to approve releases - #9786
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
dcramer
reviewed
Oct 6, 2026
sentry-junior
Bot
changed the title
dcramer
marked this pull request as ready for review
October 6, 2026 21:30
BYK
approved these changes
Oct 6, 2026
BYK
left a comment
BYK
left a comment
Member
There was a problem hiding this comment.
Ideally we'd extend our write-access check to bots too but let's go with this for now.
BYK
added a commit
that referenced
this pull request
Oct 7, 2026
…9797) ## Summary - Accept `getsantry[bot]` approvals for exact `auto-approve-repos.txt` repository/path entries; reject other targets, including changed requests. - Require the exact GitHub bot login, stable numeric actor ID, and `Bot` type for both Getsantry and Junior at the initial label event and subsequent live-event checks. GitHub issue label events expose actor IDs but no performing-App/installation ID. - Retain Junior's existing target scope and human write/admin checks. ## Validation - Fail-first regressions covered the #9788 Getsantry event, swapped/missing bot IDs, lookalike actors, changed targets, and malformed paths. - `pnpm test -- --printConsoleTrace`: 18 files, 148 tests passed. - `pnpm lint`, Prettier checks, generated-parser check, workflow YAML parsing, and `git diff --check` passed. Fixes #9772 Refs #9788, #9786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9693 rejects
acceptedlabels from every[bot]account exceptsentry-internal-app[bot]. That broke Junior's release flow: on #9771,sentry-junior[bot]addedacceptedand the workflow removed it, so a human had to approve the release by hand.This adds an allowlist of trusted Sentry-operated release bots, which can approve any valid getsentry publish target. For now
sentry-junior[bot]is the only entry. Other bots are still rejected, and malformed repos or publish paths still fail before the allowlist is checked. The rest of #9693 stays as-is: per-target authorization for humans, revalidation beforeci-ready, and revoking stranded labels. Every approval check (publish.ymlandci-poller.yml) goes throughauthorizeApproval, so all of them pick up the allowlist.Refs #9772
via David Cramer.
--
View Junior Session [Sentry]