Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/sdk/src/areas/hosts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import type {
HostRetryUpdateResponse,
UpdateHostRequest,
} from "@bb/server-contract";
import type { SdkResponseLike } from "../response.js";
import { signalRequestArgs, type CreateSdkAreaArgs } from "./common.js";

export interface HostGetArgs {
Expand Down Expand Up @@ -144,7 +145,7 @@ export function createHostsArea(args: CreateSdkAreaArgs): HostsArea {
);
},
async installProviderCli(input) {
const response = await transport.resolve(
const response: SdkResponseLike = await transport.resolve(
transport.api.v1.hosts[":id"]["provider-clis"].install.$post({
param: { id: input.hostId },
json: {
Expand All @@ -153,7 +154,7 @@ export function createHostsArea(args: CreateSdkAreaArgs): HostsArea {
},
}),
);
const text = await Response.prototype.text.call(response);
const text = await response.text();
return text
.split(/\r?\n/u)
.filter((line) => line.trim().length > 0)
Expand Down
58 changes: 58 additions & 0 deletions packages/sdk/test/host-installer-response.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import { createBbSdk } from "../src/core.js";
import { createHttpTransport } from "../src/transport-http.js";

const NativeResponse = globalThis.Response;

class AlternateResponse extends NativeResponse {
#readText = () => super.text();

override text(): Promise<string> {
return this.#readText();
}
}

afterEach(() => {
vi.unstubAllGlobals();
});

describe("host installer response readers", () => {
it("reads native installer events when the global Response is replaced", async () => {
const events = [
{ type: "started", provider: "test-provider", command: "test-installer" },
{
type: "output",
provider: "test-provider",
stream: "stdout",
text: "ready",
},
{
type: "completed",
provider: "test-provider",
exitCode: 0,
signal: null,
success: true,
},
];
const response = new NativeResponse(
events.map((event) => JSON.stringify(event)).join("\r\n\n") + "\n",
);
const sdk = createBbSdk({
transport: createHttpTransport({
baseUrl: "http://bb.test",
runtime: "node",
fetch: async () => response,
}),
});
vi.stubGlobal("Response", AlternateResponse);

await expect(
sdk.hosts.installProviderCli({
hostId: "test-host",
provider: "test-provider",
actionKind: "update",
}),
).resolves.toEqual(events);
expect(response.bodyUsed).toBe(true);
});
});
Loading