Fix SDK installer response reader dispatch - #3469
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The SDK applied the global Response prototype’s body reader to a transport response. With the server’s Hono wrapper installed globally, a native Fetch response lacks the wrapper’s private receiver state and event parsing throws.
Reproduction and root-cause report
What changed
Read installer events through the returned response’s own text method. Use the existing SdkResponseLike interface to accommodate the generated client’s streamed-response type. Add a regression test using a native response with a different global Response implementation.
63 changed text lines (61 additions, 2 deletions), across two SDK files. No dependencies, generated files, stored data, or public contracts change.
How you verified
this[getResponseCache] is not a functionin two clean checkouts of trusted main; the same reproduction passes after the fix.pnpm exec turbo run test typecheck --filter=@bb/sdk: all 105 tests and typecheck pass.git diff --checkpassed; no binary changes; EAP codename scan clean.Fixes #3467