Skip to content

Fix SDK installer response reader dispatch - #3469

Open
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3467
Open

Fix SDK installer response reader dispatch#3469
bb-slop-cop[bot] wants to merge 1 commit into
mainfrom
slopcop/issue-3467

Conversation

@bb-slop-cop

@bb-slop-cop bb-slop-cop Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🚨 SLOP COP 🚨 · new-issue-autopilot

Human comments

What was wrong

The SDK applied the global Response prototype’s body reader to a transport response. With the server’s Hono wrapper installed globally, a native Fetch response lacks the wrapper’s private receiver state and event parsing throws.

Reproduction and root-cause report

What changed

Read installer events through the returned response’s own text method. Use the existing SdkResponseLike interface to accommodate the generated client’s streamed-response type. Add a regression test using a native response with a different global Response implementation.

63 changed text lines (61 additions, 2 deletions), across two SDK files. No dependencies, generated files, stored data, or public contracts change.

How you verified

  • The focused regression test failed before the production change with a private receiver-state error.
  • The actual locked Hono wrapper reproduced this[getResponseCache] is not a function in two clean checkouts of trusted main; the same reproduction passes after the fix.
  • pnpm exec turbo run test typecheck --filter=@bb/sdk: all 105 tests and typecheck pass.
  • Trusted base full Turbo build: 20 tasks passed.
  • git diff --check passed; no binary changes; EAP codename scan clean.

Fixes #3467

AGENT GENERATED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installProviderCli fails on native Response

1 participant