Repository navigation
fix: reject undecodable images, let zero-budget keys shadow wildcards π #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b660554
fix(llm): reject prompt images that do not decode π
kp2pml30 36d78e2
feat(ci): land a PR by fast-forwarding its base on /genvm-fast-forward β¨
kp2pml30 616fb9d
build(deps): bump wasmtime to 48.0.3 β¬οΈ
kp2pml30 072d9ea
fix(fees): let a zero-budget exact key shadow internal wildcards π
kp2pml30 7c1748a
build(deps): bump puppeteer-core to 25.12.0 and the webdriver to Nodeβ¦
kp2pml30 e4252e5
docs(fees): say when a zero-budget internal key fails on its budget π
kp2pml30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| name: branch / fast-forward command | ||
|
|
||
| # `/genvm-fast-forward` lands a PR by moving its base branch to the PR head, | ||
| # without a merge or squash commit. The tool gates on approvals, required checks | ||
| # and E2E, since the deploy key it pushes with bypasses the base's rulesets. | ||
| # The resulting push triggers the usual executor branch sync | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| permissions: {} | ||
|
|
||
| # One request per PR at a time; across PRs the non-force push keeps landings safe | ||
| concurrency: | ||
| group: fast-forward-command-${{ github.event.issue.number }} | ||
| cancel-in-progress: false | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash -exo pipefail {0} | ||
|
|
||
| jobs: | ||
| fast-forward: | ||
| # The association only spares strangers the deploy key; the tool authorizes | ||
| if: >- | ||
| github.event.issue.pull_request && | ||
| github.event.comment.body == '/genvm-fast-forward' && | ||
| contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| checks: read | ||
| contents: read | ||
| issues: write | ||
| pull-requests: write | ||
| statuses: read | ||
| steps: | ||
| # issue_comment workflows run from the default branch. Keep that trusted | ||
| # checkout: the deploy key is in scope, so no PR code may run here. | ||
| # Full history, so git can show the push builds on the base | ||
| - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up manager push access | ||
| env: | ||
| MANAGER_DEPLOY_KEY: ${{ secrets.GENVM_CI_PRIVATE_KEY }} | ||
| run: | | ||
| install -m700 -d ~/.ssh | ||
| key="${RUNNER_TEMP}/manager_push_key" | ||
| set +x | ||
| printf '%s\n' "$MANAGER_DEPLOY_KEY" > "$key" | ||
| set -x | ||
| chmod 600 "$key" | ||
| git config --global url."git@github.com:".insteadOf "https://github.com/" | ||
| echo "GIT_SSH_COMMAND=ssh -i $key -o IdentitiesOnly=yes -o StrictHostKeyChecking=accept-new" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Verify and fast-forward | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PR_NUMBER: ${{ github.event.issue.number }} | ||
| COMMENT_ID: ${{ github.event.comment.id }} | ||
| COMMENT_BODY: ${{ github.event.comment.body }} | ||
| SENDER: ${{ github.event.sender.login }} | ||
| RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
| run: ./support/ci/run.sh tool fast-forward-command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule v0.2.x
updated
7 files
Submodule v0.3.x
updated
20 files
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Maintainability & Code Quality | π‘ Minor | β‘ Quick win
Fix the grammar of gate 3.
The phrase "every check the base requires succeeded" reads as a double verb. Reword it.
Proposed fix
π Committable suggestion
π§° Tools
πͺ LanguageTool
[style] ~43-~43: The double modal βrequires succeededβ is nonstandard (only accepted in certain dialects). Consider βto be succeededβ.
Context: ...ests` and every check the base requires succeeded on the head 4. The head is strictly ahe...
(NEEDS_FIXED)
π€ Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robo-kp2pml30: valid nit, deferred. The sentence parses as a reduced relative clause, and a docs-only push now would invalidate the green E2E on
e4252e5. It will go in with the next change to this pageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kp2pml30Understood. This is a clarity nit, not a grammar error. Deferring it until the next page change avoids invalidating the green E2E result.Would you like a follow-up issue for this nit?
You are interacting with an AI system.