Repository navigation
Conversation
flemzord
marked this pull request as ready for review
October 9, 2026 15:40
NumaryBot
approved these changes
Oct 9, 2026
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auth can now use a product-owned embedded plugin or an independently distributed executable. The host shares provider selection and exact-version checks between Auth and Ledger, while retaining credentials, connection selection and terminal behavior.
plugins install,syncandshowaccept--service auth; Ledger remains the default. Auth and Ledger retain independent target locks. Catalogue discovery accepts YAML or JSON and uses the official registry, with embedded fallback for unprepared targets when no matching official release is available. Help and completion remain offline.Depends on formancehq/auth#162. The Auth dependency points to its published branch revision with verified Go checksums and no local replacement. This PR targets
feat/stack-v4-cli, which contains the v4 foundation; it does not include the entire v3-to-v4 rewrite againstmain.Evidence
After: Auth and Ledger use shared loading and distribution boundaries, and fctl embeds the product-owned Auth package.
just pc, the fulljust testsrace suite and targeted SDK race tests pass after syncing the current v4 foundation. The dependency is fetched from GitHub without a local workspace.Merge Danger
Door: two-way
Blast Radius: CLI
Provider preparation, catalogue discovery and Auth dependency loading change. Only Auth and Ledger service roots are accepted, and foreign service overrides are rejected. No data migration, deployment, registry upload or official catalogue publication is performed. Merge the Auth dependency PR and confirm its final module revision before merging this PR.