Repository navigation
Conversation
Contributor
|
🟡 [minor] Reconcile contradictory patch wire-format documentation The Instances section says patch sends merge-patch directly to spec without a spec wrapper (lines 85–86), but the newly added installation section says the product wraps that same input as {"spec":...} for the API (lines 120–122). Readers implementing an API client or diagnosing patch requests receive two incompatible descriptions of the HTTP payload. Suggestion: Keep the CLI input documented as a spec-only object, and update the Instances section to explicitly distinguish that input from the product's wrapped API request body. Remove the claim that the HTTP request has no spec wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Load Connectivity through the shared external service-plugin loader, alongside Auth and Ledger. Connectivity commands and forms now come from an installed product executable and its cached manifest; the host retains connection settings, credentials, HTTP authentication and terminal interaction. Remove the embedded
plugins/connectivitypackage without adding a Go dependency on the product module.Companion product Draft PR: https://github.com/formancehq/connectivity/pull/402.
Stacked on #193 (
feat/auth-generic-plugins, baseline c07b2b5). The requested local aff263e was not available on this machine or GitHub; the user authorized using the GitHub branch instead.Behavior and compatibility
--service connectivity. Install/sync/show, directconnectivity-url, stack service resolution, Cloud targets and cached offline help/completion use the generic loader. Service locks remain independent for Auth, Ledger and Connectivity.NewRootCommandWithArgs./_inforequest per execution and prevents a cached successful version check from allowing later writes after version drift. It cannot make discovery and a subsequent business HTTP request atomic across mixed-version backends.Validation
FCTL_CONNECTIVITY_TEST_BINARY=/absolute/path/to/product/build/fctl-plugin-connectivity nix develop --command just pre-commit testspassed, including host and SDK race tests.FCTL_CONNECTIVITY_TEST_BINARYis absent;docs/validation.mddocuments qualification without importing/building product sources in the host.