Skip to content

fix(OSQUERY-008): CU-86akhf8u2 File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(OSQUERY-008): CU-86akhf8u2 File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions osquery/events/tests/linux/inotify_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ namespace fs = boost::filesystem;
namespace osquery {
DECLARE_bool(enable_file_events);

namespace {
const int kMaxEventLatency = 3000;

@flamingo flamingo Bot Sep 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention

Wrapped const int kMaxEventLatency = 3000; in an anonymous namespace (namespace { ... } // namespace) directly where it was declared inside namespace osquery, giving it internal linkage per translation unit and satisfying OSQUERY-007 scoping convention while preserving its use in all subsequent TEST_F bodies unchanged.

🤖 Prompt for AI agents 
In osquery/events/tests/linux/inotify_tests.cpp around line 32, review and complete this code-review fix: File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention.
What the draft fix changed: Wrapped `const int kMaxEventLatency = 3000;` in an anonymous namespace (`namespace { ... } // namespace`) directly where it was declared inside `namespace osquery`, giving it internal linkage per translation unit and satisfying OSQUERY-007 scoping convention while preserving its use in all subsequent `TEST_F` bodies unchanged.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer

} // namespace

class INotifyTests : public testing::Test {
bool enable_file_events_backup{false};
Expand Down
Loading