fix(OSQUERY-008): CU-86akhf8u2 File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention

[flamingo]

Closes findings from rule OSQUERY-008 — File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🟢 95 high	File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention	osquery/events/tests/linux/inotify_tests.cpp:32

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 46e37628-c6c9-49a4-aa29-9b30b2c8be3f

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akhf8u2 Osquery review findings sweep (15 PRs)

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff.

[flamingo]

🦩 🟠 File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention

Wrapped const int kMaxEventLatency = 3000; in an anonymous namespace (namespace { ... } // namespace) directly where it was declared inside namespace osquery, giving it internal linkage per translation unit and satisfying OSQUERY-007 scoping convention while preserving its use in all subsequent TEST_F bodies unchanged.

🤖 Prompt for AI agents

In osquery/events/tests/linux/inotify_tests.cpp around line 32, review and complete this code-review fix: File-scope constant kMaxEventLatency violates established kPascalCase-only scoping/anonymous-namespace convention.
What the draft fix changed: Wrapped `const int kMaxEventLatency = 3000;` in an anonymous namespace (`namespace { ... } // namespace`) directly where it was declared inside `namespace osquery`, giving it internal linkage per translation unit and satisfying OSQUERY-007 scoping convention while preserving its use in all subsequent `TEST_F` bodies unchanged.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer