Skip to content

chore: let the commit hook accept amend! commits #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthware-dev merged 1 commit into from
Sep 23, 2026
Merged

chore: let the commit hook accept amend! commits #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/framework/test_commit_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def test_real_subjects_from_the_history(self, subject):
"Merge branch 'main' into feat/x",
'Revert "feat(photos): something"',
"fixup! fix(core): something",
"amend! fix(core): something",
])
def test_git_writes_these_itself(self, subject):
"""Linting them teaches people to pass --no-verify, nothing else."""
Expand Down
2 changes: 1 addition & 1 deletion tools/commit-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ HEADER = re.compile(

# Git writes these itself, or they are machine-made and never reach a
# changelog. Linting them would only teach people to pass --no-verify.
EXEMPT = re.compile(r"^(Merge |Revert \"|fixup! |squash! |Bumps )")
EXEMPT = re.compile(r"^(Merge |Revert \"|fixup! |squash! |amend! |Bumps )")


def check(header: str) -> list[str]:
Expand Down
Loading