Conversation
Contributor
Preview this PR in the Nextcloud Playground
A fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## test/coverage-page-controllers #122 +/- ##
====================================================================
+ Coverage 94.93% 95.12% +0.19%
- Complexity 114 124 +10
====================================================================
Files 19 20 +1
Lines 513 533 +20
Branches 54 54
====================================================================
+ Hits 487 507 +20
Misses 19 19
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
erseco
marked this pull request as ready for review
September 22, 2026 04:18
erseco
added this pull request to stack #124
September 22, 2026 05:37
erseco
force-pushed
the
refactor/editor-legacy-migration-service
branch
from
September 22, 2026 05:38
32be43e to
6422b8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.elp→.elpxrename logic out ofEditorControllerLegacyFileMigrationServicelib/Servicecoverage scope, so the new service must keep the backend above 90%Why
This is the fourth stacked step toward covering
EditorController. The repository testing guidance recommends extracting logic from controllers into collaborator-driven services rather than building a fake Nextcloud container in unit tests.Stack
Depends on #121 → #120 → #119.
The next/final PR will cover the remaining EditorController orchestration using this service.
Validation