Conversation
Contributor
Preview this PR in the Nextcloud PlaygroundA fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/editor-legacy-migration-service #123 +/- ##
===========================================================================
Coverage ? 93.75%
Complexity ? 150
===========================================================================
Files ? 22
Lines ? 657
Branches ? 54
===========================================================================
Hits ? 616
Misses ? 34
Partials ? 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
erseco
marked this pull request as ready for review
September 22, 2026 04:22
erseco
added this pull request to stack #124
September 22, 2026 05:37
erseco
force-pushed
the
test/coverage-editor-controller
branch
from
September 22, 2026 05:38
d4f6935 to
957d17e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditorHtmlServiceEditorControllerauthentication, id/path resolution, initial state, CSP, save error paths, missing editor, and iframe responseEditorControllerto the backend Clover scopeStack
Depends on #122 → #121 → #120 → #119.
This is the final planned PR in the stacked PHP coverage series.
Validation
lib/: 93.03%lib/Controller: 92.78%lib/Service: 95.92%lib/AppInfo: 100%lib/Preview: 83.33%src/: 95.45%EditorController: 85% linesEditorHtmlService: 100% linesLegacyFileMigrationService: 100% lines