Skip to content

Make newly created saved views immediately searchable - #2691

Open
niemyjski wants to merge 2 commits into
mainfrom
issue/saved-view-create-consistency
Open

niemyjski wants to merge 2 commits into
mainfrom
issue/saved-view-create-consistency

Conversation

@niemyjski

@niemyjski niemyjski commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Latest head aaef7949 merges main at 89607b48; the incoming change is documentation-only (CONTRIBUTING.md). Application, test, and workflow trees are unchanged. CI on this head is queued; the passing results below cover the preceding head.

Saved-view creation could return 201 before Elasticsearch exposed the new view to list queries. Navigating to the new view then rendered a 404, even though a later list request found it. Creation now uses native immediate consistency before returning, matching predefined-view writes. This isolates the inherited blocker observed in #2630 from its authentication changes.

Validation: deterministic HTTP regression failed before the fix and passed afterward; all 130 saved-view endpoint tests passed. The affected browser scenario passed three consecutive runs with retries disabled; the final build passed with zero warnings/errors. Full CI passed on 5a1609c4, including all backend shards, frontend validation/tests, image builds, and 124 browser scenarios with zero retries. No API response or schema changes.

Verification and implementation details

The regression initializes predefined views, disables automatic refresh only for the fixture's saved-view index, creates a view, and immediately queries both organization and event-view lists. It uses no sleep, polling, or intervening refresh, and restores the refresh interval in finally.

Production change: add ImmediateConsistency() to the existing create operation. No frontend delay, retry, or cache policy changes.

Local integration verification used a disposable Elasticsearch container with tmpfs storage. Temporary fixture and AppHost changes are excluded from this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:56:39.407622Z 5a1609c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 22% 130 ❌
Exceptionless.Core 78% 70% 10988 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 86% 72% 9427 ✔
Summary 81% (28620 / 35495) 70% (14329 / 20504) 20915 ✔

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant