Repository navigation
Patch System.Security.Cryptography.Pkcs for .NET security advisories - #2662
Merged
Merged
Conversation
MimeKit (through MailKit) allows System.Security.Cryptography.Pkcs 10.0.0, which GHSA-2fmv-rv2c-59x7 and GHSA-846f-f764-76mx (CVE-2026-70162 and CVE-2026-84008, published October 13) flag. NuGet audit treats those warnings as errors, so restore fails on every branch. Reference the patched 10.0.13 directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
ejsmith
added a commit
that referenced
this pull request
Nov 5, 2026
* Patch System.Security.Cryptography.Pkcs for .NET advisories (#2662) (cherry picked from commit 71e779d) * Fix build failures from vulnerable MessagePack dependency (#2671) * Patch MessagePack dependency to restore secure builds * Include remaining MessagePack 2.5 security fixes (cherry picked from commit fa3590a) * Explain OAuth client scope consent errors (#2638) * Explain OAuth client scope consent failures * Revalidate consent state when the authorization query changes * Exercise live OAuth administrator consent and refresh flow * Clarify validated OAuth consent controls and reuse problem messages * Use concrete membership collection in OAuth regression test * Address OAuth consent error handling review (cherry picked from commit 731b471) * Let users grant every scope to self-registered OAuth clients MCP clients request every scope discovery advertises, but a dynamically registered client was stored without stacks:write. Consent rejected the whole request with invalid_scope, so the client could never be approved. A self-registered client chooses its own scopes and could register again with all of them, so that list restricts nothing. Those clients may now request any supported scope, and the user's consent limits the grant. Scopes an administrator saved stay enforced: consent offers only the allowed ones and the final authorization request is still strict. (cherry picked from commit 190f6d7) * Adapt consent browser tests to the 8.10 application paths The consent tests from #2638 assume the Svelte application at the site root, which landed after 8.10. Point the mocked consent test at /next and remove the live consent test, which also depends on metadata routes and API origin handling this branch does not have. Remove the validation test cases that depend on a validation change from #2608 and format the file. * Keep administrator settings when client metadata changes A metadata refresh overwrote an administrator's saved settings and reset UpdatedByUserId, which made the application count as self-registered and lifted its scope restriction. Skip the refresh once an administrator has saved the application. (cherry picked from commit 6690fdb) * Fix website build Deno compatibility (#2599) --------- Co-authored-by: Blake Niemyjski <bniemyjski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore fails on every branch since October 13: NuGet audit flags
System.Security.Cryptography.Pkcs10.0.0 (GHSA-2fmv-rv2c-59x7, GHSA-846f-f764-76mx, both .NET denial of service), andTreatWarningsAsErrorsturns the warnings into errors. The package comes in through MailKit's MimeKit 4.18.1, which allows 10.0.0. This references the patched 10.0.13 directly fromExceptionless.Insulation, the project that references MailKit.Validation: restore and build of
Exceptionless.slnxwith no warnings; the Web, Job, and Insulation projects resolve 10.0.13;MailerTests(35) pass. Local restore did not reproduce the audit error even with a fresh HTTP cache, so CI confirms the audit result. This unblocks CI and/previewfor open PRs such as #2661 and #2634.🤖 Generated with Claude Code