Repository navigation
Hotfix 8.10.1: Fix MCP sign-in for self-registered clients - #2722
Merged
Merged
Conversation
(cherry picked from commit 71e779d)
* Patch MessagePack dependency to restore secure builds * Include remaining MessagePack 2.5 security fixes (cherry picked from commit fa3590a)
* Explain OAuth client scope consent failures * Revalidate consent state when the authorization query changes * Exercise live OAuth administrator consent and refresh flow * Clarify validated OAuth consent controls and reuse problem messages * Use concrete membership collection in OAuth regression test * Address OAuth consent error handling review (cherry picked from commit 731b471)
MCP clients request every scope discovery advertises, but a dynamically registered client was stored without stacks:write. Consent rejected the whole request with invalid_scope, so the client could never be approved. A self-registered client chooses its own scopes and could register again with all of them, so that list restricts nothing. Those clients may now request any supported scope, and the user's consent limits the grant. Scopes an administrator saved stay enforced: consent offers only the allowed ones and the final authorization request is still strict. (cherry picked from commit 190f6d7)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 474c3802ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The consent tests from #2638 assume the Svelte application at the site root, which landed after 8.10. Point the mocked consent test at /next and remove the live consent test, which also depends on metadata routes and API origin handling this branch does not have. Remove the validation test cases that depend on a validation change from #2608 and format the file.
A metadata refresh overwrote an administrator's saved settings and reset UpdatedByUserId, which made the application count as self-registered and lifted its scope restriction. Skip the refresh once an administrator has saved the application. (cherry picked from commit 6690fdb)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for production MCP sign-in, without shipping the 9.0 work on
main. Merging this does not deploy; pushing thev8.10.1tag does.Commits
System.Security.Cryptography.Pkcsv8.10.0no longer restores: NuGet audit errorsWebsitecheck and the tag's website jobDifferences from main
validation.test.ts: dropped three 422 cases that depend on avalidation.tschange from Replace legacy Angular UI with root Svelte application #2608, which isn't on this base.oauth-consent.e2e.tsnow targets/next, because 8.10 serves the UI there.oauth-live-consent.e2e.tsis removed here only. It needs routes and API origin handling this branch lacks; it still runs onmain.Verification
Run against a live local stack built from this branch, on ES 8.19.21.
Scenarios covered: clients registered with and without
stacks:write, write allowed in approved orgs and denied in others, refresh keeping write, a user declining write, and admin restrictions.After merge
mainfirst, so it has the fix too.git tag v8.10.1 origin/release/8.10 && git push origin v8.10.1https://api.exceptionless.io/api/v2/aboutreports8.10.1.The tag also publishes the website. Compared with the live site, only
docs/docs/api/index.mdchanges (the new scope docs).