Repository navigation
Camera: say why buttons are disabled, disable them during a scan; Edge glow threshold and Smoothing hints (#173) - #178
Merged
Conversation
…e glow threshold and Smoothing hints (#173) Calibrate / Check exposure and Check framing show their reason beside them and in their tooltip, as Scan does: the engine is down, open the output window, or choose a camera. While a scan runs, Show preview, Calibrate, Check framing and Skip an area are disabled with "The scan is using the camera". Edge glow's Sensitivity is now Edge threshold ("Higher: only strong edges"); same key, range and direction, so saved shows look the same. Number settings can carry a hint (the control's tooltip) and step names: Smoothing reads Off / Low / High, still saved as 0..2. Assisted-by: Claude Code:claude-opus-5-5
…abled (#173) The camera panel was updated only on status, which the engine doesn't send on scan start or end: its buttons stayed enabled into a scan and disabled after it. renderScanButton() now updates it, on status and on every scan message. A status arriving mid-calibrate no longer re-enables the busy button. Effect setting hints also reach screen readers (aria-description). Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
force-pushed
the
issue-173-disabled-reasons
branch
from
October 23, 2026 19:03
02905ff to
320cc52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
What changes
engine/effect_settings.jsonunchanged).hint(shown as the control's tooltip) andsteps(named readout). Smoothing reads Off / Low / High with hint "Ignores speckle in the scan. Off: every edge, High: only clean lines"; still saved as 0, 1, 2.Tests
cameraPanel.browser.test.ts: reasons for no output window, no camera, engine down; everything that needs the camera disabled during a scan and re-enabled after. Replaces the old test that expected Calibrate to stay enabled mid-scan.controls.test.ts: Edge threshold label/hint/range, Smoothing hint and Off/Low/High readout.make test: engine 289 passed; frontend 383 passed, 5 WebGL browser tests timed out under load (syncGroups, motion, text, edgeglowLook) and pass when rerun alone (14/14). Spelling check OK.After review
renderScanButton(), so it followsscan_started/scan_result/scan_failed/scan_canceledright away, not only the next status. No test covers this: no test mountsmain.ts.aria-descriptionon the slider.