Repository navigation
Camera section: exposure verdict first, one Check exposure button, settings labeled per camera (#172) - #179
Merged
Merged
Conversation
…ttings labeled per camera (#172) The engine judges a saved exposure (good or at the light limit) and sends the range it judged by, so the Editor quotes the engine's levels instead of keeping its own. A failed check leads with its verdict ("Too dark", "Clipping"). The button is Check exposure for every camera; the result says whether it adjusted a webcam or only checked a still camera. With nothing saved, the readout says the scan checks it first. The section is split into Before scanning and Scan settings for <camera>, each setting with a visible label and a one-line hint. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
…copy fails (#172) Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172
What changes
camera.exposure(verdict: good / light_limit, plus the engine'slow/high/targetrange), computed byexposure_verdict()inengine/calibrate.pyfrom the saved calibration. The Editor quotes those numbers and has no copy of 120/180/250. The saved calibration format is unchanged, andat_light_limiton status stays as it was.#exposure-noteshows the engine's message as-is. The old "Exposure check failed:" / "Calibration failed:" prefix is gone, so a 409 such as "Output window is not connected" now shows on its own in the warning color.#exposure-note) leads with the verdict and says what it did: "Good: adjusted the camera to exposure 1200, gain 3" (webcam) or "Good: checked the exposure set on the camera; nothing changed on it" (still camera).<label>and a one-line hint linked byaria-describedby; Skip an area has a hint too. The option text drops the "Aperture:"/"HDR:" prefix, and the optionvalues are unchanged, so saved per-camera settings load as before. The tooltips on those rows were removed in favor of the hints. Check framing keeps itstitle, which the Camera: say why buttons are disabled, disable them during a scan; Edge glow threshold and Smoothing hints (#173) #178 test relies on.frontend/src/shared/fixtures/engine-messages.jsonwas regenerated withUPDATE_MESSAGE_FIXTURES=1for the new status field.Not in scope: moving the camera picker or a setup checklist (#168).
Tests
Written test-first, each seen red before the change: the engine verdict and status field (
test_calibrate.py), the still-camera 422 verdict wording (test_still_scan.py), the readout text (statusView.test.ts), the button name, the adjusted/checked result, the light-limit note, and the grouping/labels/hints (cameraPanel.browser.test.ts).uv run pytest -q: 291 passed, 11 skippednpx tsc --noEmit: OKnpx vitest run --maxWorkers=2: 394 passed, 1 skippedNot verified
Not checked by hand in the real Editor. Laying the selects out in the
.controlgrid changes their width compared with the old.row, so the look is unverified.