Skip to content

fix(auth): harden PIN unlock submission - #208

Merged
LiranCohen merged 1 commit into
fix/auth-initialization-recoveryfrom
fix/pin-unlock-rejection
Sep 18, 2026
Merged

LiranCohen merged 1 commit into
fix/auth-initialization-recoveryfrom
fix/pin-unlock-rejection

Conversation

@LiranCohen

@LiranCohen LiranCohen commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove delayed PIN completion timers that could fire after edits or navigation
  • route keyboard, input, and paste completion through one synchronous helper
  • rely on the existing auth-provider and screen busy guards instead of adding a second component-level submission latch
  • settle parent-owned PIN and passkey rejections through one shared event-handler helper

Stack

Depends on #207. Merge #217, #207, then this PR.

Verification

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 75.68% (🎯 25%) 3499 / 4623
🟢 Statements 73.98% (🎯 25%) 3723 / 5032
🟢 Functions 74.6% (🎯 30%) 1099 / 1473
🟢 Branches 68.96% (🎯 29%) 2396 / 3474
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ui/PinInput.tsx 80.7% 67.53% 91.66% 83.5% 58, 87-116, 176
src/features/auth/UnlockScreen.tsx 95.23% 89.47% 100% 100% 50, 57
Generated in workflow #537 for commit 2e3cf5e by the Vitest Coverage Report Action

@LiranCohen
LiranCohen force-pushed the fix/pin-unlock-rejection branch from fdcd3c0 to 74e6cc5 Compare September 18, 2026 14:37
@LiranCohen
LiranCohen changed the base branch from main to fix/auth-initialization-recovery September 18, 2026 14:51
@LiranCohen
LiranCohen force-pushed the fix/pin-unlock-rejection branch from 74e6cc5 to 2053ef6 Compare September 18, 2026 15:20
@LiranCohen LiranCohen changed the title fix(auth): make PIN unlock submission single-flight fix(auth): harden PIN unlock submission Sep 18, 2026
@LiranCohen
LiranCohen changed the base branch from fix/auth-initialization-recovery to main September 18, 2026 15:24
@LiranCohen
LiranCohen changed the base branch from main to fix/auth-initialization-recovery September 18, 2026 15:26
@LiranCohen
LiranCohen force-pushed the fix/pin-unlock-rejection branch from 2053ef6 to c1754a8 Compare September 18, 2026 20:10
@LiranCohen
LiranCohen added this pull request to stack #218 September 18, 2026 20:31
@LiranCohen
LiranCohen force-pushed the fix/pin-unlock-rejection branch from c1754a8 to 2e3cf5e Compare September 18, 2026 20:38
@LiranCohen
LiranCohen merged commit 05460e2 into main Sep 18, 2026
4 of 8 checks passed
@LiranCohen
LiranCohen deleted the fix/pin-unlock-rejection branch September 18, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant