Repository navigation
fix(auth): allow cancelling stalled passkey prompts - #215
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
LiranCohen
force-pushed
the
fix/passkey-unlock-cancel
branch
from
September 18, 2026 14:39
43e2a24 to
25467ec
Compare
LiranCohen
force-pushed
the
fix/passkey-unlock-cancel
branch
from
September 18, 2026 15:20
25467ec to
6d915bd
Compare
LiranCohen
force-pushed
the
fix/passkey-unlock-cancel
branch
from
September 18, 2026 20:10
68d0c1f to
c929586
Compare
LiranCohen
force-pushed
the
fix/passkey-unlock-cancel
branch
from
September 18, 2026 20:38
c929586 to
a69a08a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When WebAuthn fails to present a platform prompt, the unlock screen currently traps the user on a spinner until the 60-second safety timeout. The underlying passkey request is already abortable, but the UI exposes no way to use that lifecycle.
Show a Cancel passkey request action only while waiting for WebAuthn. It aborts the active request signal, returns to Unlock using passkey, and permits a clean retry; once wallet opening has begun, the existing non-cancellable Opening wallet state remains unchanged. The local cancellation race also settles promptly in browsers that do not honor WebAuthn abort signals.
Stack
Depends on #208. Merge #208, then this PR, then #212.
Verification