Skip to content

fix(auth): allow cancelling stalled passkey prompts - #215

Merged
LiranCohen merged 3 commits into
fix/pin-unlock-rejectionfrom
fix/passkey-unlock-cancel
Sep 18, 2026
Merged

LiranCohen merged 3 commits into
fix/pin-unlock-rejectionfrom
fix/passkey-unlock-cancel

Conversation

@LiranCohen

@LiranCohen LiranCohen commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

When WebAuthn fails to present a platform prompt, the unlock screen currently traps the user on a spinner until the 60-second safety timeout. The underlying passkey request is already abortable, but the UI exposes no way to use that lifecycle.

Show a Cancel passkey request action only while waiting for WebAuthn. It aborts the active request signal, returns to Unlock using passkey, and permits a clean retry; once wallet opening has begun, the existing non-cancellable Opening wallet state remains unchanged. The local cancellation race also settles promptly in browsers that do not honor WebAuthn abort signals.

Stack

Depends on #208. Merge #208, then this PR, then #212.

Verification

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 75.77% (🎯 25%) 3506 / 4627
🟢 Statements 74.03% (🎯 25%) 3730 / 5038
🟢 Functions 74.55% (🎯 30%) 1099 / 1474
🟢 Branches 69% (🎯 29%) 2400 / 3478
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/App.tsx 69.42% 52.5% 68.96% 69.02% 72-85, 102-103, 110, 167-169, 203-208, 215-216, 226-230, 269, 301-316, 328, 334-347, 368
src/features/auth/UnlockScreen.tsx 93.47% 87.5% 100% 100% 50, 57, 73
Generated in workflow #539 for commit a69a08a by the Vitest Coverage Report Action

@LiranCohen
LiranCohen force-pushed the fix/passkey-unlock-cancel branch from 43e2a24 to 25467ec Compare September 18, 2026 14:39
@LiranCohen
LiranCohen changed the base branch from main to fix/pin-unlock-rejection September 18, 2026 14:51
@LiranCohen
LiranCohen force-pushed the fix/passkey-unlock-cancel branch from 25467ec to 6d915bd Compare September 18, 2026 15:20
@LiranCohen
LiranCohen changed the base branch from fix/pin-unlock-rejection to main September 18, 2026 15:24
@LiranCohen
LiranCohen changed the base branch from main to fix/pin-unlock-rejection September 18, 2026 15:26
@LiranCohen
LiranCohen force-pushed the fix/passkey-unlock-cancel branch from 68d0c1f to c929586 Compare September 18, 2026 20:10
@LiranCohen
LiranCohen added this pull request to stack #218 September 18, 2026 20:31
@LiranCohen
LiranCohen force-pushed the fix/passkey-unlock-cancel branch from c929586 to a69a08a Compare September 18, 2026 20:38
@LiranCohen
LiranCohen merged commit 99258e8 into main Sep 18, 2026
4 checks passed
@LiranCohen
LiranCohen deleted the fix/passkey-unlock-cancel branch September 18, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant